Skip to content

Release artifacts for release v1.4.0 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Release artifacts for release v1.4.0 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b67f8f
Release artifacts for release v1.4.0
michaelhtm Apr 1, 2025
a6d0d76
Nit changes before release
michaelhtm Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/dynamodb-controller
newTag: 1.3.0
newTag: 1.4.0
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: dynamodb-chart
description: A Helm chart for the ACK service controller for Amazon DynamoDB (DynamoDB)
version: 1.3.0
appVersion: 1.3.0
version: 1.4.0
appVersion: 1.4.0
home: https://github.com/aws-controllers-k8s/dynamodb-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/dynamodb-controller:1.3.0".
This chart deploys "public.ecr.aws/aws-controllers-k8s/dynamodb-controller:1.4.0".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/dynamodb-controller
tag: 1.3.0
tag: 1.4.0
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down
6 changes: 4 additions & 2 deletions pkg/resource/table/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,10 @@ func customPreCompare(
a.ko.Spec.DeletionProtectionEnabled = aws.Bool(false)
}

if a.ko.Spec.ContributorInsights == nil && b.ko.Spec.ContributorInsights != nil &&
*b.ko.Spec.ContributorInsights == string(svcsdktypes.ContributorInsightsActionDisable) {
// Making this field a no-op if user does not set it.
// This will ensure controller does not act on this field
// if user is unaware of it.
if a.ko.Spec.ContributorInsights == nil {
a.ko.Spec.ContributorInsights = b.ko.Spec.ContributorInsights
}
}
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/tests/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from e2e.replacement_values import REPLACEMENT_VALUES

RESOURCE_PLURAL = "tables"

CREATE_WAIT_AFTER_SECONDS = 30
DELETE_WAIT_AFTER_SECONDS = 15
MODIFY_WAIT_AFTER_SECONDS = 90

Expand Down Expand Up @@ -71,6 +71,8 @@ def create_table(name: str, resource_template):
name, namespace="default",
)

time.sleep(CREATE_WAIT_AFTER_SECONDS)

# Create table
k8s.create_custom_resource(table_reference, resource_data)
table_resource = k8s.wait_resource_consumed_by_controller(table_reference)
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/tests/test_table_replicas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from acktest.k8s import condition

RESOURCE_PLURAL = "tables"

CREATE_WAIT_AFTER_SECONDS = 30
DELETE_WAIT_AFTER_SECONDS = 30
MODIFY_WAIT_AFTER_SECONDS = 600
REPLICA_WAIT_AFTER_SECONDS = 600
Expand Down Expand Up @@ -113,6 +113,7 @@ def create_table_with_invalid_replicas(name: str):
)
logging.debug(resource_data)

time.sleep(CREATE_WAIT_AFTER_SECONDS)
# Create the k8s resource
ref = k8s.CustomResourceReference(
CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
Expand Down