Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release artifacts for release v1.4.0 #128

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Release artifacts for release v1.4.0 #128

merged 2 commits into from
Apr 2, 2025

Conversation

michaelhtm
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 April 1, 2025 19:30
@ack-prow ack-prow bot added the approved label Apr 1, 2025
a-hilaly
a-hilaly approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@michaelhtm
Copy link
Member Author

/retest

@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@a-hilaly
Copy link
Member

a-hilaly commented Apr 1, 2025

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 1, 2025 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dynamodb-verify-attribution a6d0d76 link false /test dynamodb-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 732e683 into aws-controllers-k8s:main Apr 2, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees

@a-hilaly a-hilaly

@rushmash91 rushmash91

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhtm @a-hilaly @rushmash91