Skip to content

late init VPCEndpoint.PolicyDocument field #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

late init VPCEndpoint.PolicyDocument field #47

merged 1 commit into from
Mar 30, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1205

Description of changes:

  • Late initializes PolicyDocument field so VPCEndpoint can achieve Synced state if PolicyDocument is not provided in the Spec. This is necessary because the API defaults PolicyDocument, if not provided.
  • Updates related test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from bwagner5 and vijtrip2 March 30, 2022 21:05
@vijtrip2
Copy link

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 67545f7 into aws-controllers-k8s:main Mar 30, 2022
@brycahta brycahta deleted the late-init-vpce branch March 30, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants