Skip to content

Add CacheClusterNotFound terminal code #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

echen-98
Copy link
Contributor

This fixes the failing negative scenario where we attempt to create a replication group with a primaryClusterID of a node that doesn't exist. Removed the skip marker from the test as it passes locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@echen-98
Copy link
Contributor Author

From Prow run: [gw2] [ 45%] PASSED tests/test_replicationgroup.py::TestReplicationGroup::test_rg_invalid_primary

Copy link
Contributor

@kumargauravsharma kumargauravsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echen-98

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: echen-98, kumargauravsharma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [echen-98,kumargauravsharma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kumargauravsharma kumargauravsharma merged commit ad25c11 into aws-controllers-k8s:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants