Skip to content

Add CacheClusterNotFound terminal code #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2021-09-13T18:13:33Z"
build_hash: c6e8ce29423336f827d2ca5c737595561c84539c
build_date: "2021-09-16T23:00:17Z"
build_hash: e4d2ea41769ef5eda245946f462ef7c1c6840409
go_version: go1.15.2
version: v0.13.2
version: v0.14.0
api_directory_checksum: 69c917d1e1ee2b196c23799a02417b920297bc74
api_version: v1alpha1
aws_sdk_go_version: v1.38.52
generator_config_info:
file_checksum: 68bcd4be3880f0774c1a4b02a56da6caff19a87e
file_checksum: 261e03a6b9fb25805b045293947f13e5674d2924
original_file_name: generator.yaml
last_modification:
reason: API generation
1 change: 1 addition & 0 deletions apis/v1alpha1/generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ resources:
- InvalidCacheSecurityGroupState
- CacheParameterGroupNotFound
- InvalidKMSKeyFault
- CacheClusterNotFound
fields:
AllowedScaleUpModifications:
is_read_only: true
Expand Down
1 change: 1 addition & 0 deletions generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ resources:
- InvalidCacheSecurityGroupState
- CacheParameterGroupNotFound
- InvalidKMSKeyFault
- CacheClusterNotFound
fields:
AllowedScaleUpModifications:
is_read_only: true
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/metrics-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "app.fullname" . }}-metrics
name: {{ .Chart.Name | trimSuffix "-chart" | trunc 44 }}-controller-metrics
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: {{ include "app.name" . }}
Expand Down
3 changes: 2 additions & 1 deletion pkg/resource/replication_group/sdk.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion test/e2e/tests/test_replicationgroup.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ def test_rg_cmd_fromsnapshot(self, rg_cmd_fromsnapshot):
assert k8s.wait_on_condition(reference, "ACK.ResourceSynced", "True", wait_periods=30)

# if primaryClusterID is a nonexistent node, the terminal condition should be set
@pytest.mark.blocked # TODO: remove when passing
def test_rg_invalid_primary(self, rg_invalid_primary):
(reference, _) = rg_invalid_primary
sleep(DEFAULT_WAIT_SECS)
Expand Down