Test: Unit test for update training job #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananth102
requested review from
akartsky,
surajkota and
ryansteakley
as code owners
ryansteakley
approved these changes
Dec 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ananth102, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Jan 19, 2024
* feat: warm pool * added custom code * test: unit tests * fix: hack for HPO and warmpool * fix: futureproofing * format: reformat one file * fix: made pr changes * added unit test * fix: use conditions instead of requeue error * unit test fixes * Feature: Update TrainingJob * test: added integration test * fix: corrected hook * fix: small typo * fix: corrected spelling/grammar erorrs * fix: handle invalid update * refactor: changed comments/terminal condition * Feature: Update TrainingJob * preliminary changes * final test suite * fix: corrected grammar mistake * test: added another test and enhanced descriptions. * updated unit teat * [test] corrected rebase errors * . * fix/test: added nil check and new unit test * Feature: Update TrainingJob * test: added integration test * fix: corrected hook * fix: small typo * fix: corrected spelling/grammar erorrs * fix: handle invalid update * refactor: changed comments/terminal condition * updated test * test: added more cases to improve coverage * updates comments and removed unnecessary nil check * fix: do not remove profiler * regnerated controller * regenerating controller * test: unit test change * pr changes * unit test and general code changes * updated unit tests * updated test * changed delta * removed redundant nil check * refactor: changed variable names * updated update input logic * minor refactor * updated unit test * changed function to method * Using requeue on sucess instead of resource synced * modified unit tests * fix: setting the status of desired * updating unit tests * fixed merge issues * corrected spelling * updated descriptions * changed error strings * changed error strings * control flow modifications * logic improvements and clarifying comments * new test structure * testfix * another fix * revert test modification * modified terminal conditions * updated unit test * changed error messaged and removed redundant check * taking out hpo custom code * eliminate api call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merge after #179
Unit tests for update training job.
File changes:
sagemaker-controller/pkg/resource/training_job/testdata/v1alpha1/update/*- Test filessagemaker-controller/pkg/resource/training_job/testdata/sdkapi/update- Mock api responsessagemaker-controller/pkg/resource/training_job/testdata/test_suite.yaml- Test casessagemaker-controller/pkg/resource/training_job/manager_test_suite_test.go- Change to support update API