Skip to content

Test: Unit test for update training job #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 103 commits into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
533f971
feat: warm pool
ananth102 Oct 21, 2022
abf0ae6
added custom code
ananth102 Oct 21, 2022
e945860
test: unit tests
ananth102 Oct 24, 2022
abece9a
fix: hack for HPO and warmpool
ananth102 Oct 25, 2022
cd58a3c
fix: futureproofing
ananth102 Oct 25, 2022
362f7ff
format: reformat one file
ananth102 Oct 25, 2022
3318693
fix: made pr changes
ananth102 Oct 27, 2022
ce4bf78
added unit test
ananth102 Oct 28, 2022
3f9b43c
fix: use conditions instead of requeue error
ananth102 Nov 10, 2022
ecb27ef
unit test fixes
ananth102 Nov 23, 2022
4b1b379
Feature: Update TrainingJob
ananth102 Nov 18, 2022
b28e26f
test: added integration test
ananth102 Nov 18, 2022
8c79de8
fix: corrected hook
ananth102 Nov 21, 2022
60747ea
fix: small typo
ananth102 Nov 21, 2022
5a5a178
fix: corrected spelling/grammar erorrs
ananth102 Nov 21, 2022
22a72b0
fix: handle invalid update
ananth102 Nov 22, 2022
baab0a6
refactor: changed comments/terminal condition
ananth102 Nov 22, 2022
095c65d
Feature: Update TrainingJob
ananth102 Nov 18, 2022
0d70417
preliminary changes
ananth102 Nov 21, 2022
2f07868
final test suite
ananth102 Nov 21, 2022
a8a5eab
fix: corrected grammar mistake
ananth102 Nov 21, 2022
585fbe3
test: added another test and enhanced descriptions.
ananth102 Nov 21, 2022
ac99419
updated unit teat
ananth102 Nov 22, 2022
84a11ee
[test] corrected rebase errors
ananth102 Nov 28, 2022
3e1f116
.
ananth102 Nov 28, 2022
cc44a3b
fix/test: added nil check and new unit test
ananth102 Nov 28, 2022
5cfd8f8
Feature: Update TrainingJob
ananth102 Nov 18, 2022
f4b6dc3
test: added integration test
ananth102 Nov 18, 2022
8cc3af3
fix: corrected hook
ananth102 Nov 21, 2022
80bdeb1
fix: small typo
ananth102 Nov 21, 2022
2937df2
fix: corrected spelling/grammar erorrs
ananth102 Nov 21, 2022
284d011
fix: handle invalid update
ananth102 Nov 22, 2022
e939d58
refactor: changed comments/terminal condition
ananth102 Nov 22, 2022
6f15902
updated test
ananth102 Nov 28, 2022
169cda1
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Nov 28, 2022
1255e9c
test: added more cases to improve coverage
ananth102 Nov 29, 2022
a4ee4eb
updates comments and removed unnecessary nil check
ananth102 Nov 29, 2022
429f875
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Nov 29, 2022
3c67e9d
fix: do not remove profiler
ananth102 Nov 29, 2022
593eb1c
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Nov 29, 2022
bb8b817
Merge branch 'main' into warmpool
ananth102 Nov 30, 2022
a6ba9c6
Merge branch 'main' into warmpool
ananth102 Nov 30, 2022
c77bd6a
regnerated controller
ananth102 Nov 30, 2022
d489136
Merge branch 'warmpool' into updatetrain3
ananth102 Nov 30, 2022
0036889
regenerating controller
ananth102 Nov 30, 2022
55498ba
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Nov 30, 2022
83afbb7
test: unit test change
ananth102 Nov 30, 2022
09db3c8
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Nov 30, 2022
b3098cd
pr changes
ananth102 Dec 2, 2022
5aea3c1
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
77f9918
unit test and general code changes
ananth102 Dec 2, 2022
e0cda88
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
63e716f
updated unit tests
ananth102 Dec 2, 2022
d7f828a
updated test
ananth102 Dec 2, 2022
bb62dd3
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
c75de8c
changed delta
ananth102 Dec 2, 2022
7ffb551
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
872ecd2
removed redundant nil check
ananth102 Dec 2, 2022
c19e37e
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
9910ffd
refactor: changed variable names
ananth102 Dec 2, 2022
80923cc
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
8a6e212
updated update input logic
ananth102 Dec 2, 2022
3be7d4f
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 2, 2022
1c94a65
minor refactor
ananth102 Dec 3, 2022
17fe79f
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 3, 2022
67b7714
updated unit test
ananth102 Dec 3, 2022
fa963fb
changed function to method
ananth102 Dec 5, 2022
bac3e8e
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 5, 2022
f46ca2a
Using requeue on sucess instead of resource synced
ananth102 Dec 5, 2022
f963d7d
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 5, 2022
ca85f94
modified unit tests
ananth102 Dec 5, 2022
7e7398e
fix: setting the status of desired
ananth102 Dec 6, 2022
90a9ff8
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 6, 2022
a1651c6
updating unit tests
ananth102 Dec 6, 2022
7ed63aa
Merge branch 'main' into updatetrain3
ananth102 Dec 6, 2022
77438b9
fixed merge issues
ananth102 Dec 6, 2022
7e69b95
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 6, 2022
e86f002
corrected spelling
ananth102 Dec 7, 2022
3663ab0
updated descriptions
ananth102 Dec 7, 2022
8538820
changed error strings
ananth102 Dec 7, 2022
3355d8a
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
2a92351
changed error strings
ananth102 Dec 7, 2022
7340891
control flow modifications
ananth102 Dec 7, 2022
f50304a
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
819e9c0
logic improvements and clarifying comments
ananth102 Dec 7, 2022
ebe99d4
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
05a331f
new test structure
ananth102 Dec 7, 2022
580795a
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
23852b5
testfix
ananth102 Dec 7, 2022
ac0e606
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
ed6a315
another fix
ananth102 Dec 7, 2022
a0a627c
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
dc04ed0
revert test modification
ananth102 Dec 7, 2022
1951518
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
d3454ce
modified terminal conditions
ananth102 Dec 7, 2022
5ac30f5
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
68a1ffa
updated unit test
ananth102 Dec 7, 2022
d35727f
changed error messaged and removed redundant check
ananth102 Dec 7, 2022
c941d6b
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
72bc374
taking out hpo custom code
ananth102 Dec 7, 2022
131b8a1
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
4a12b3d
eliminate api call
ananth102 Dec 7, 2022
abf7de3
Merge branch 'updatetrain3' into updatetrain-unittests
ananth102 Dec 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2022-12-06T04:24:52Z"
build_date: "2022-12-07T21:20:55Z"
build_hash: 6e2ffbc3b16a30ac59be6719918c601c2c864064
go_version: go1.19.1
version: v0.20.1-3-g6e2ffbc-dirty
api_directory_checksum: d1a8286cb85155b185875aae9e3a72beaf720595
go_version: go1.17.13
version: v0.20.1-3-g6e2ffbc
api_directory_checksum: 48886052888c7166740636bc128afdb53d05a4cb
api_version: v1alpha1
aws_sdk_go_version: v1.44.93
aws_sdk_go_version: v1.44.117
generator_config_info:
file_checksum: afd4f10e7b9ed9b76e24dfcfefb646c024b03271
file_checksum: 60bfaf57553c2e031a3e78bc8bb9c3535ad8ada8
original_file_name: generator.yaml
last_modification:
reason: API generation
3 changes: 1 addition & 2 deletions apis/v1alpha1/app.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

166 changes: 164 additions & 2 deletions apis/v1alpha1/enums.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 34 additions & 2 deletions apis/v1alpha1/generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ resources:
compare:
is_ignored: true
TrainingJob:
reconcile:
requeue_on_success_seconds: 300
exceptions:
errors:
404:
Expand All @@ -186,8 +188,14 @@ resources:
hooks:
delta_pre_compare:
code: customSetDefaults(a, b)
delta_post_compare:
code: customPostCompare(b, a, delta)
sdk_read_one_post_set_output:
code: rm.customSetOutput(&resource{ko})
sdk_update_post_build_request:
template_path: training_job/sdk_update_post_build_request.go.tpl
sdk_update_post_set_output:
template_path: training_job/sdk_update_post_set_output.go.tpl
sdk_delete_pre_build_request:
template_path: training_job/sdk_delete_pre_build_request.go.tpl
sdk_delete_post_request:
Expand Down Expand Up @@ -229,7 +237,27 @@ resources:
priority: 1
from:
operation: DescribeTrainingJob
path: FailureReason
path: FailureReason
WarmPoolStatus:
is_read_only: true
from:
operation: DescribeTrainingJob
path: WarmPoolStatus
ProfilingStatus:
is_read_only: true
from:
operation: DescribeTrainingJob
path: ProfilingStatus
LastModifiedTime:
is_read_only: true
from:
operation: DescribeTrainingJob
path: LastModifiedTime
CreationTime:
is_read_only: true
from:
operation: DescribeTrainingJob
path: CreationTime
AlgorithmSpecification.MetricDefinitions:
compare:
is_ignored: true
Expand Down Expand Up @@ -972,7 +1000,6 @@ ignore:
- Workforce
- Workteam
operations:
- UpdateTrainingJob
- UpdateFeatureGroup
shape_names:
# RSessionAppSettings is an empty struct that causes generation errors
Expand All @@ -982,7 +1009,12 @@ ignore:
- ExecutionRoleIdentityConfig
- HyperParameterTuningResourceConfig
- InstanceMetadataServiceConfiguration
- CanvasAppSettings
- ExplainerConfig
- HyperParameterTuningJobStrategyConfig
- DisableProfiler
field_paths:
- StartPipelineExecutionInput.ClientRequestToken
- CreatePipelineInput.ClientRequestToken
- CreatePipelineInput.PipelineDefinitionS3Location

17 changes: 17 additions & 0 deletions apis/v1alpha1/training_job.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading