Increasing test timeouts and disabling stop tests #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the code change in model-monitor but everything else references model-package? |
ananth102
changed the title
Fixed, resource names are similar. |
ryansteakley
approved these changes
Apr 6, 2023
surajkota
requested changes
Apr 6, 2023
| ) | ||
| == self.STATUS_PENDING | ||
| ) | ||
| assert k8s.wait_on_condition(reference, "ACK.ResourceSynced", "False", 5, 2) | ||
|
|
||
| self._assert_monitoring_schedule_status_in_sync( |
There was a problem hiding this comment.
do we need to increase wait time for this check?
also can we do the same for feature group?
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
surajkota
requested changes
Apr 7, 2023
|
/approve |
ananth102
changed the title
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ananth102, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ananth102
added a commit
to ananth102/ack-sagemaker-controller
that referenced
this pull request
Apr 7, 2023
…s#235) Issue #, if available: Description of changes: Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced. Also increasing timeouts and disabling test_*_stopped tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ananth102
added a commit
to ananth102/ack-sagemaker-controller
that referenced
this pull request
Apr 7, 2023
…s#235) Issue #, if available: Description of changes: Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced. Also increasing timeouts and disabling test_*_stopped tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ananth102
added a commit
that referenced
this pull request
Apr 10, 2023
Issue #, if available: Description of changes: Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced. Also increasing timeouts and disabling test_*_stopped tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Jan 19, 2024
…s#235) Issue #, if available: Description of changes: Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced. Also increasing timeouts and disabling test_*_stopped tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced.
Also increasing timeouts and disabling test_*_stopped tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.