Skip to content

Cherry-Pick: Increasing test timeouts and disabling stop tests #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

ananth102
Copy link
Member

Description of changes:

Cherry picking canary fixes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…s#235)

Issue #, if available:

Description of changes:

Monitoring Schedule can sometimes reach the scheduled state before the controller can verify that it is in Pending state. This PR removes the check for pending/resource synced.

Also increasing timeouts and disabling test_*_stopped tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@ack-prow
Copy link

ack-prow bot commented Apr 7, 2023

@ananth102: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-metadata-file-test f607ae3 link true /test sagemaker-metadata-file-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@surajkota
Copy link
Member

/approve
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ananth102,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ananth102 ananth102 merged commit c53e8c8 into aws-controllers-k8s:release-v1.2.0 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants