Skip to content

feat(context): improve hooks execution UI #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

hayemaxi
Copy link
Contributor

Update the UI of running hooks to align with the loading UI of MCP.

Screen.Recording.2025-04-17.at.9.02.10.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hayemaxi hayemaxi self-assigned this Apr 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 65.45455% with 57 lines in your changes missing coverage. Please review.

Project coverage is 14.27%. Comparing base (4e14852) to head (56eebe1).

Files with missing lines Patch % Lines
crates/q_cli/src/cli/chat/tools/execute_bash.rs 20.40% 37 Missing and 2 partials ⚠️
crates/q_cli/src/cli/chat/hooks.rs 84.54% 16 Missing and 1 partial ⚠️
crates/q_cli/src/cli/chat/mod.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1280   +/-   ##
=======================================
  Coverage   14.26%   14.27%           
=======================================
  Files        2366     2366           
  Lines      205904   205935   +31     
  Branches   186268   186299   +31     
=======================================
+ Hits        29379    29397   +18     
- Misses     175061   175075   +14     
+ Partials     1464     1463    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hayemaxi hayemaxi marked this pull request as ready for review April 18, 2025 01:13
@hayemaxi hayemaxi requested a review from a team April 18, 2025 01:13
@hayemaxi hayemaxi linked an issue Apr 18, 2025 that may be closed by this pull request
Update the UI of running hooks to align with the loading UI of MCP.
@hayemaxi hayemaxi requested a review from brandonskiser April 19, 2025 00:39
@brandonskiser brandonskiser merged commit 61c953c into aws:main Apr 21, 2025
11 checks passed
This was referenced Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align /context hooks UI with MCP loading UI
3 participants