Skip to content

fix: shortens tip message to avoid overflow subtraction #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Conversation

dingfeli
Copy link
Contributor

Issue #, if available:

Description of changes:
This is for an emergent deployment.
This will likely have a follow up fix.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dingfeli dingfeli requested a review from a team April 29, 2025 06:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.47%. Comparing base (4cb1fce) to head (3a55e38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   14.47%   14.47%           
=======================================
  Files        2345     2345           
  Lines      204312   204312           
  Branches   184676   184676           
=======================================
  Hits        29568    29568           
  Misses     173287   173287           
  Partials     1457     1457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dingfeli dingfeli merged commit 5d2c280 into main Apr 29, 2025
19 of 21 checks passed
@dingfeli dingfeli deleted the shorten-tip-msg branch April 29, 2025 06:18
This was referenced Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants