Skip to content

chore(config-resolver): refactor regionInfo types to improve readability #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 26, 2021

Issue

Internal JS-2904

Description

Moves RegionHash and PartitionHash to new files to simplify exports/imports.
Defines Options interface in each files to avoid including redundant options and extending multile interfaces.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(config-resolver): move RegionHash and PartitionHash to new files chore(config-resolver): refactor regionInfo types to improve readibility Oct 26, 2021
@trivikr trivikr changed the title chore(config-resolver): refactor regionInfo types to improve readibility chore(config-resolver): refactor regionInfo types to improve readability Oct 26, 2021
@trivikr trivikr requested a review from AllanZhengYP October 26, 2021 06:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #2934 (be93e5b) into main (5e1d297) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head be93e5b differs from pull request most recent head ea5272e. Consider uploading reports for the commit ea5272e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
- Coverage   58.57%   58.57%   -0.01%     
==========================================
  Files         558      558              
  Lines       30249    30248       -1     
  Branches     7443     7443              
==========================================
- Hits        17719    17718       -1     
  Misses      12530    12530              
Impacted Files Coverage Δ
...ig-resolver/src/regionInfo/getResolvedPartition.ts 100.00% <ø> (ø)
...fig-resolver/src/regionInfo/getHostnameTemplate.ts 100.00% <100.00%> (ø)
...es/config-resolver/src/regionInfo/getRegionInfo.ts 100.00% <100.00%> (ø)
...fig-resolver/src/regionInfo/getResolvedHostname.ts 100.00% <100.00%> (ø)
clients/client-sts/src/endpoints.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/src/endpoints.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/src/endpoints.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/src/endpoints.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json-10/src/endpoints.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1d297...ea5272e. Read the comment docs.

@trivikr trivikr marked this pull request as draft October 26, 2021 16:06
@trivikr trivikr marked this pull request as ready for review October 26, 2021 16:30
@trivikr trivikr marked this pull request as draft October 26, 2021 17:08
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🚀

@trivikr trivikr merged commit 4df3162 into aws:main Oct 26, 2021
@trivikr trivikr deleted the region-info-export-types branch October 26, 2021 18:00
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants