fix(config-resolver): get signingRegion from regionRegex if not present for FIPS #2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
trivikr
force-pushed
the
signing-region-regionRegex
branch
from
bcd37ae to
4981e1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
+ Coverage 58.57% 58.59% +0.02%
==========================================
Files 558 560 +2
Lines 30248 30264 +16
Branches 7443 7448 +5
==========================================
+ Hits 17718 17734 +16
Misses 12530 12530
Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Oct 27, 2021
packages/config-resolver/src/regionInfo/getResolvedSigningRegion.ts
Outdated
Show resolved
Hide resolved
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
JS-2904
This PR will be rebased, and made ready after intermediate PR #2934 is merged.PR is ready!Description
Gets signingRegion from regionRegex if not present for FIPS endpoints.
Testing
yarn test:functionalis successful.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.