feat: add support for browser streaming #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add http request type guard for middlewares header default middleware expect continue middleare * chore: add http request type guard for apply body checksum middlewares * chore: only build and test demo smithy client * feat: add isInstance to httpResponse * chore: update rds data model * chore: update to ts3.7; update rds model#3 * chore: update tsconfig to genenerte types only once * chore: update gitignore * chore: parse body with streamCollector * chore: add error deserialization * chore: stub Field union * fix: fix middleware-header-default test * fix: fix retry-middleware unit test
* feat: remove 'apply' entry from configuration definition 'apply' was used to adjust middleware stack and resolved configuration. It is not relative as we are moving to conposition configuration, and middleware stack should not be altered by configurations. Address: aws#94 * feat: complete PoC composable configuration * feat: change config resolver to multiple client config components * feat: rename stack finalize step to finalizeRequest * feat: add use() to smithy client to inject middleware * fix: rename resolvedruntime configuration * fix: remove exported reviouslyResolved interface * feat: add metadatabearer to shapes * feat: parse derializing utils as parameters * use config interface as middleware parameter * use smithy command as super class of all commands so we can support use() in commands * feat: parse serialize(deserialize) util functions from client config * Serializers/Deserializers should take utils functions from client config first, if not available then fallback to generated dependencies. This allows configuring the runtime dependencies manually from client config when runtime-specific bundlers' decision is not accountable * feat: add metadata deserializer * docs: add documentation for config properties * feat: add defaultUserAgen config * feat: move some config components to middleware folder * signing middleware * retry middleware; Also update retry config interface by introducing RetryStrategy class * feat: add input type proxy for better intellisense * docs: add config doc block for retry config * feat: add a user agent middleware to support custom useragent
…#389) * feat: add RetryStrategy class and change retryMiddleware interface
* feat: remove generated SerDe runtime dependencies Instead, use the runtime-specific utils specified in client config * fix: change plugin interface to callback functions mutating the stack
* feat: support pluggable runtime config * export runtimeConfig.runtime.ts to manually set the client to be compatible with specific runtime * get rid of rollup, instead using browser property to swap runtime config * add endpoint to the serializer utilities and insert it when building a request * chore: set prettier-vscode as default formatter
* fix: remove duplicated declaration of endpoints * fix: rename serializerUtils to serializerContext
* feat: combine serde types, cleanup unused imports * feat: update model location * feat: change Injectable to Pluggable
* feat: move serde into command
* feat: remove rest-json protocol class * feat: rename handler to RequestHandler; Consolidate types
feat: name package feat: migrate and apply middleware feat: remove $ input options feat: remove preformedBucket option
* fix: add BucketEndpoint config plugin * fix: package exports
…ddleware (aws#574) * fix: use host name from request instead of endpont provider * fix: assure bucketEndpointMw applies before hostHeaderMw
AllanZhengYP
added
the
smithy-codegen
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
reviewed
Dec 27, 2019
There was a problem hiding this comment.
There are some concerns about arrayBuffer not supported in Mobile browsers (Chrome/Firefox), and we'll handle them today.
| ): Promise<Uint8Array> => { | ||
| return new Response(stream) | ||
| .arrayBuffer() | ||
| .then(arrayBuffer => new Uint8Array(arrayBuffer)); |
There was a problem hiding this comment.
add .catch() block here to throw for abort/error
|
The MDN data over
|
trivikr
force-pushed
the
smithy-codegen
branch
from
f2f891c to
f226993
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #102 browser streaming as removed from preview because
ReadableStreamsupport in browsers was not ideal back then. Now since most of the browser vendors support ReadableStream, we can enable the feature.Previously, the
fetch-http-handlerreturns a promise ofblobfor body, even when we expect the body to be streaming sometimes(e.g. S3 GetObject). After these change, we can return aReadableStreamfor streaming response in browser. This would avoid loading all the resposne body data in the brwoser memory.reference:
Responseconstructor: https://fetch.spec.whatwg.org/#response-classReadableStreambrowser support: https://caniuse.com/#search=ReadableStreamBodyAPI is needed for converting readable stream toTypedArray:fetch: https://developer.apple.com/documentation/webkitjs/fetchresponse/2871267-arraybufferBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.