Make tests pass on Windows #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunch of changes. Here's some highlights: Code Changes - Refactored ScalacWorker to abstract common code between Scala 2 & 3 - Refactored dependency-analyzer plugin javaargs to use ‘;’ as a delimiter instead of ‘:’ - Renamed a couple function names containing rpathlocation to rlocationpath - added lineEndings=preserve to scalafmt.conf - added .bazelrc to enable needed flags for Windows Test Changes - disable running tests for features not-supported on Windows - make tests handle fact that sh_binary outputs .exe on Windows - Handle other Windows specifics where needed (i.e. backslash as pathseparator, crlf linendings, dependence on bash)
liucijus
reviewed
Dec 14, 2023
| @@ -0,0 +1 @@ | |||
| build --enable_runfiles | |||
There was a problem hiding this comment.
Can --enable_runfiles be put under windows config?
liucijus
reviewed
Dec 14, 2023
| } | ||
|
|
||
| @annotation.tailrec | ||
| def tokenize(tokens:List[String], targetsStr:String, currTokenStartIdx:Int, currIdx:Int, isEscaped:Boolean) : List[String] = { |
There was a problem hiding this comment.
nit: return type probably can be Seq[String]
liucijus
reviewed
Dec 14, 2023
test/shell/test_examples.sh
Outdated
| bazel build //... | ||
| ) | ||
| echo dude |
simuons
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bunch of changes. Here's some highlights:
Code Changes
Test Changes
Other notes:
Motivation
Keeping the tests working on Windows greatly helps ensure continuous compatibility with Windows OS.