Fix to close the compiler object in scalacinvoker #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes functionality that was accidently broken in PR#1529
simuons
requested changes
Feb 13, 2024
Done
I looked at dotty's sourcecode, and they don't have a close() mechanism like Scala2 does yet. There is a PR written up for it scala/scala3#5412. Suggest we push this PR through, and deal with Scala3 when dotty implements that PR. |
liucijus
approved these changes
Feb 17, 2024
simuons
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes functionality that was accidently broken in PR #1529 (my bad).
The fix is to call close on the compiler within the scalaCWorker (originally added in PR #1504)