-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bzz)
manifest.toml, line 3 at r1 (raw file):
name = "C++" language = "cpp" aliases = ["C++","C"]
Completely trivial nit: Space between elements, please (like features).
Signed-off-by: Denys Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @bzz and @creachadair)
manifest.toml, line 3 at r1 (raw file):
Previously, creachadair (M. J. Fromberger) wrote…
Completely trivial nit: Space between elements, please (like features).
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bzz)
Signed-off-by: Denys Smirnov <[email protected]>
Signed-off-by: Denys Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 3 of 3 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
manifest.toml, line 3 at r3 (raw file):
name = "C++" language = "cpp" aliases = ["C++", "C", "CUDA", "OpenCL", "Metal"]
My immediate reaction was "but we can't index those!" But the syntax is compatible, it's (mainly) only the intrinsics that break type-checking.
Update SDK, Go version and enable language aliases.
Addresses src-d/gitbase#728
Signed-off-by: Denys Smirnov [email protected]
This change is