Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Enable language aliases #39

Merged
merged 3 commits into from
May 28, 2019
Merged

Enable language aliases #39

merged 3 commits into from
May 28, 2019

Conversation

dennwc
Copy link
Member

@dennwc dennwc commented May 24, 2019

Update SDK, Go version and enable language aliases.

Addresses src-d/gitbase#728

Signed-off-by: Denys Smirnov [email protected]


This change is Reviewable

@dennwc dennwc requested review from creachadair and bzz May 24, 2019 17:47
@dennwc dennwc self-assigned this May 24, 2019
Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz)


manifest.toml, line 3 at r1 (raw file):

name = "C++"
language = "cpp"
aliases = ["C++","C"]

Completely trivial nit: Space between elements, please (like features).

Copy link
Member Author

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @bzz and @creachadair)


manifest.toml, line 3 at r1 (raw file):

Previously, creachadair (M. J. Fromberger) wrote…

Completely trivial nit: Space between elements, please (like features).

Done.

Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bzz)

Signed-off-by: Denys Smirnov <[email protected]>
Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 3 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


manifest.toml, line 3 at r3 (raw file):

name = "C++"
language = "cpp"
aliases = ["C++", "C", "CUDA", "OpenCL", "Metal"]

My immediate reaction was "but we can't index those!" But the syntax is compatible, it's (mainly) only the intrinsics that break type-checking.

@dennwc dennwc merged commit d7816a1 into bblfsh:master May 28, 2019
@dennwc dennwc deleted the aliases branch May 28, 2019 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants