Parsing C# doesn't work

[smacker]

Run this query on any C# repository:

SELECT UAST(f.blob_content, LANGUAGE(f.file_path, f.blob_content)) AS uast
FROM refs AS r
NATURAL JOIN commit_files
NATURAL JOIN files AS f
WHERE r.ref_name = 'HEAD' AND f.file_path REGEXP('.*.cs')
LIMIT 5

it will return empty uasts.

[erizocosmico]

SELECT UAST(f.blob_content, 'csharp') AS uast
FROM refs AS r
NATURAL JOIN commit_files
NATURAL JOIN files AS f
WHERE r.ref_name = 'HEAD' AND f.file_path REGEXP('.*.cs')
LIMIT 5

This does, so it's not a gitbase issue. It's just that bblfsh does accepts csharp and not C#, which is what enry returns.

[smacker]

bblfsh does accept c# when you send parse request. You can try it with go-client.
But gitbase doesn't because of this: https://github.com/src-d/gitbase/blob/master/internal/function/uast_utils.go#L100

so it's a problem in gitbase. though maybe it's better to wait for aliases in supported languages from LA team to fix it.

[erizocosmico]

If gitbase asks if a language is supported and bblfsh reports that it's not, it's not a problem in gitbase. It's a problem of bblfsh not correctly reporting whether a language is supported or not.

We can create a mapping between languages such as C# to translate it to csharp so bblfsh will say that it's supported, but at the end of the day it's a hack until LA adds aliases in supported languages.

[erizocosmico]

Leaving this blocked until enry/bblfsh have this fixed.

[dennwc]

Language aliases were released, see https://github.com/src-d/backlog/issues/1421#issuecomment-496659214 for more details.

[erizocosmico]

This is fixed in bblfsh side, but we cannot upgrade to go modules right now so this will be kept as blocked.

[dennwc]

Why do you need modules for this?

[erizocosmico]

Because dep cannot handle the vN suffixes used in packages using Go modules

[dennwc]

@erizocosmico According to "minimal modules compatibility" you can try getting the package without the vN suffix.

[erizocosmico]

@dennwc we can, but we're importing bblfsh go-client, which has dependencies on modules using the vN suffix (sdk, etc)

[dennwc]

But we definitely won't backport this change. Do you need any help with switching to modules in Gitbase?

[erizocosmico]

No, don't worry. Is more of a workflow and (internal gitbase) tooling issue than modules issues. We'll eventually move to go modules when we figure those out.

[ajnavarro]

Aliases support becomes a high priority now, so maybe it is the time to move on with this task.

[erizocosmico]

Will be fixed once #847 is merged

[ajnavarro]

Finally fixed on v0.21.0-beta3