Playwright_RGP_Add family member without copying proband info #2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add family member without copying proband info
marked as skip until non-prod RGP stuff is fixed, can be ran and should pass so long as there is a proband tab but if it runs into the same pt i.e. no new pts created before next run, it might fail since relationshipIDs need to be unique
Rinchan20
commented
Aug 10, 2023
| @@ -70,8 +71,8 @@ export default class RgpParticipantPage extends ParticipantPage { | |||
| const selectedRelation = await this.relation.toLocator().locator('.mat-select-value-text').innerText(); | |||
| await this.submit.click(); | |||
|
|
|||
| await expect(page.locator(modal)).toHaveText('Successfully added family member'); | |||
| await page.locator('h1').click(); // close popup with a click outside | |||
| await expect(page.locator(familyMemberAddedSuccessfullyModal)).toHaveText('Successfully added family member'); | |||
There was a problem hiding this comment.
made change since once it turns into the 'success' modal, it seems that for a split second there are 2 webelements that fit role=dialog
aweng98
approved these changes
Aug 14, 2023
Rinchan20
deleted the
create-family-member-without-copying-proband-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add family member without copying proband info