PEPPER-587: RGP DSM playwright tests_assert creation of new participant by checking DSM #2048

Rinchan20 · 2023-03-02T19:46:09Z

Extends the current RGP playwright test to check that the newly created participant can also be seen in DSM - might need a slight tweak - the most recent changes were done using DSM Test and there's a slight text difference when selecting the RGP study there (DSM Test has Pepper RGP, DSM Dev has RGP). But other than that should be running fine.

Finishes up the last part of of this ticket: https://broadworkbench.atlassian.net/browse/PEPPER-587

Changed from 'Pepper RGP' -> 'RGP' so that it'll be able to run no matter if used in dev, test, or staging

missed an eslint error

Rinchan20 · 2023-03-02T21:13:50Z

tweak from Pepper RGP -> RGP done as well

GiCharkviani · 2023-03-03T11:28:04Z

playwright-e2e/pages/dsm/home-page.ts

+  }
+
+  async selectStudy(study: string, page: Page) {
+    const studySelector = await new Select(page, { label: 'Select study' });


Instead, you could use this way: this.navigation.selectStudy()

Oh, anyway, this method is not used anywhere. Maybe remove it?

GiCharkviani · 2023-03-03T11:33:10Z

playwright-e2e/pages/dsm/home-page.ts

+   * @param opts
+   */
+  async logIn(opts: { email?: string; password?: string; waitForNavigation?: boolean } = {}) {
+    await auth.login(this.page);


I think when you are on this page, you are already logged in, therefore I don't think this method is useful here. What do you think about removing it?
Please correct me if I'm wrong.

Usually, we just call the login() method from beforeEach.
It would be good if we considered later adding Login Page Object Model, which would handle all login-related things

GiCharkviani · 2023-03-03T11:47:54Z

playwright-e2e/pages/dsm/home-page.ts

+    await studySelector.selectOption(study);
+  }
+
+  async selectStudyMenuOption(menuOption: string) {


This is not used as well

GiCharkviani · 2023-03-03T11:51:24Z

playwright-e2e/pages/dsm/home-page.ts

+    }
+  }
+
+  async selectCustomizeViewOption(columnGroup: string, columnName: string) {


This is not used as well.
If you need to use customize view functionality anywhere, you can find it in CustomizeView class, which is located in the Filters class, that is available (according to DSM structure) in the ParticipantListPage class (POM).

GiCharkviani · 2023-03-03T12:01:22Z

playwright-e2e/pages/dsm/participantList-page.ts

@@ -20,6 +24,18 @@ export default class ParticipantListPage {
    await waitForNoSpinner(this.page);
  }

+  public async filterListByParticipantGUID(participantGUID: string): Promise<void> {
+    await this.page.locator('text=Customize View >> button').click();


Instead, you could use customize view functionality, which is available from the _filters field. Like so:

const customizeViewPanel = this.filters.customizeViewPanel; await customizeViewPanel.open(); await customizeViewPanel.selectColumns('Participant Columns', ['Participant ID']); const searchPanel = this.filters.searchPanel; await searchPanel.open(); await searchPanel.text('Participant ID', {textValue:participantGUID}); await searchPanel.search();

And later to make assertions.

What do you think?

sounds good - will make the changes

playwright-e2e/tests/rgp/adult-enrollment.spec.ts

GiCharkviani · 2023-03-03T12:03:55Z

playwright-e2e/pages/dsm/home-page.ts

+import { Navigation } from 'lib/component/dsm/navigation/navigation';
+import { StudyNav } from 'lib/component/dsm/navigation/enums/studyNav.enum';
+import ParticipantListPage from 'pages/dsm/participantList-page';
+import ParticipantPage from 'pages/dsm/participant-page';


Unused import:
import ParticipantPage from 'pages/dsm/participant-page';

aweng98 · 2023-03-03T14:21:36Z

playwright-e2e/pages/dsm/home-page.ts

+      await this.navigation.selectFromStudy<ParticipantListPage>(StudyNav.PARTICIPANT_LIST);
+      await this.participantList.waitForReady();
+      await this.participantList.assertPageTitle();
+      await this.participantList.waitForReady();


Line #47 is not needed. It's dupl of line #45. assertPageTitle() does not click.

aweng98 · 2023-03-03T14:24:39Z

playwright-e2e/pages/dsm/home-page.ts

+  async waitForReady(): Promise<void> {
+    await this.page.waitForFunction(() => document.title === 'DDP Study Management');
+  }


FYI, document.title === 'DDP Study Managment' tells me current page is the expected page. But it doesn't checks page is fully loaded and ready for user interaction. Just wanted you to know this, it's okay to leave it as is.

aweng98 · 2023-03-03T14:26:29Z

playwright-e2e/pages/dsm/page-base.ts

+/**
+ * Data Study Manager (DSM) page base
+ */
+export abstract class DSMPageBase extends PageBase {


👍🏻👍🏻

aweng98 · 2023-03-03T14:28:01Z

playwright-e2e/pages/dsm/participantList-page.ts

+  ShortId = 'Short ID',
+  ParticipantID = 'Participant ID'
+}
+
 export default class ParticipantListPage {


ParticipantListPage extends DSMPageBase? because you created new abstract class DSMPageBase.

aweng98 · 2023-03-03T14:38:53Z

playwright-e2e/utils/faker-utils.ts

+export const setPatientParticipantGuid = async (page: Page) => {
+  const [response] = await Promise.all([
+    page.waitForResponse((resp) => resp.url().includes('/participants') && resp.status() === 200)
+  ]);
+
+  const participantResponse = response.url();
+  const urlArray = participantResponse.split('/');
+  user.patient.participantGuid = urlArray[6];
+};


Waiting and parsing a request in a separate function is going to make tests flaky because request could have been finished before this function starts to run. Best way to do this is, perform action and wait for response together a in Promise.all.

await Promise.all([ some_action(), waitForResponse() ]);

will do - thinking a bit more about this one - in terms of which action to use - will make the changes

playwright-e2e/tests/rgp/adult-enrollment.spec.ts

aweng98

Test failed on my localhost. Can you take a look?

aweng98 · 2023-03-16T13:55:51Z

playwright-e2e/tests/rgp/adult-enrollment.spec.ts


-test.describe('Adult Self Enrollment', () => {
+test.describe.serial('Adult Self Enrollment', () => {


Will take a look at the test and fix it post haste

initial investigation - seems to run well in my localhost - but for some reason the pt above is in the dev database but doesn't seem to exist in elastic search - looking more into it and will report back

kibana seems to be slow - so it might be more than a couple of mins

correction - I used test env when checking local run - that's why it's working for me - new RGP pts since about March 10th don't seem to be appearing in DSM and that's why the test failed - looking into it

*don't seem to be appearing in DSM dev I mean

aweng98 · 2023-03-16T17:05:03Z

playwright-e2e/package-lock.json

+        "eslint-plugin-prettier": "^4.2.1",
+        "prettier": "^2.8.4",


I have removed prettier and related plugin. Do you think we want to keep it?

no - let's take it out (will do!) - it ended up getting put in while using vs code

filling out more proband automation in prep for family history automation

Rinchan20 · 2023-05-19T20:31:19Z

remaining work: some feedback, comparison between copied family member and proband (DSM), checking messages display (DSS) and then should be end to end. Will also add blood rnaseq column check. Then most apart from kit upload for RGP should be automated with this PR.

flakiness in checking contents of Participant Info notes after revisiting page seems to be mostly fixed

Rinchan20 · 2023-05-24T16:15:40Z

PR currently adds the last 5 tests seen in the below photo - the test ("Verify that a family member can be added using copied proband info") is halfway done - copied family member is made, comparison to the proband just needs to be done - currently running on test due to dev housekeeping issues:

(not sure if photo of tests with runtimes will display in github)

move out most dsm related tests to its own script since test run time was approaching 180 seconds which is temporarily extended while doing testing - test time for dsm related stuff is now 70 seconds - will likely combine a test or two - other tests are skipped so that a run focuses on only adult enrollment and dsm - also when child enrollment fails screenshot comparison the guid info seems lost somehow - will get rid of skips once kit upload and dashboard part is done

aweng98 · 2023-06-05T20:33:36Z

playwright-e2e/package.json

@@ -16,15 +16,17 @@
  },
  "devDependencies": {
    "@faker-js/faker": "^7.6.0",
-    "@playwright/test": "^1.31.1",
+    "@playwright/test": "^1.33.0",


Don't upgrade Playwright version in this PR because you would also need to update CI Playwright docker image version, update test screenshots on Dev, Test and docker container.

currently rgp tests check the following: dss enrollment survey -> dsm to check the pt is there -> check the rgp dynamic fields -> family member creation -> kit upload. Added method to get most recent playwright pt. Added stuff from other pr since merge both option wasn't seen.

@proband

the @proband annotation is temporary while cleaning up tests

forgot to make family enrollment tests serial, the first test now searches for the most recently created automated pt and the rests of the tests after that should consistently use whatever pt the first test found. Could use refactoring later. My additions seem to pass in docker container now.

Rinchan20 · 2023-06-12T14:01:27Z

Plan is to break this PR into smaller PRs - a bit on hold until this ticket is done: https://broadworkbench.atlassian.net/browse/PEPPER-692 (since it will fail consistently in dev otherwise - currently passes when ran in tests which has less/minimal housekeeping issues)

Rinchan20 · 2023-08-15T15:00:54Z

handled by other smaller PRs - closing this one

Rinchan20 · 2023-08-15T15:04:20Z

handled by PRs such as:

Rinchan20 added 2 commits March 2, 2023 14:18

PR for checking the new RGP pt is located in DSM

bbd993f

Merge branch 'develop' into rgp_dsm_playwright_tests

e14f1f2

Rinchan20 requested review from aweng98 and zyme March 2, 2023 19:46

Rinchan20 added 3 commits March 2, 2023 15:06

Update adult-enrollment.spec.ts

8726024

Changed from 'Pepper RGP' -> 'RGP' so that it'll be able to run no matter if used in dev, test, or staging

ESLint errors fixed

3af6483

Update faker-utils.ts

a5c04ad

missed an eslint error

GiCharkviani self-requested a review March 3, 2023 11:21

GiCharkviani reviewed Mar 3, 2023

View reviewed changes

playwright-e2e/tests/rgp/adult-enrollment.spec.ts Show resolved Hide resolved

GiCharkviani reviewed Mar 3, 2023

View reviewed changes

aweng98 reviewed Mar 3, 2023

View reviewed changes

Rinchan20 added 2 commits March 7, 2023 09:07

implementing improvement suggestions

384cba6

Merge branch 'develop' into rgp_dsm_playwright_tests

2caa969

Rinchan20 changed the title ~~PEPPER_587: RGP DSM playwright tests_assert creation of new participant by checking DSM~~ PEPPER-587: RGP DSM playwright tests_assert creation of new participant by checking DSM Mar 7, 2023

Merge branch 'develop' into rgp_dsm_playwright_tests

f9dba01

aweng98 reviewed Mar 16, 2023

View reviewed changes

Rinchan20 added 8 commits May 12, 2023 13:32

WIP

426c4d9

filling out more proband automation in prep for family history automation

contact info automated

5c6f7e7

study status automated

39752e2

medical records automated

e48a821

primary sample automated

a8239b2

tissue section in progress

d469d71

tissue section automated

8867a4d

checking family ids WIP

694159d

Rinchan20 added 2 commits May 19, 2023 16:32

Merge branch 'develop' into rgp_dsm_playwright_tests

fa4cd15

Update adult-enrollment.spec.ts

cdb83e4

flakiness in checking contents of Participant Info notes after revisiting page seems to be mostly fixed

Rinchan20 added 11 commits May 24, 2023 12:58

Merge branch 'develop' into rgp_dsm_playwright_tests

32cad26

moved things to match develop update

7a44501

fixed typo in family member enums

2d26c89

added extra check for non-copied family member

861cb6c

Create rgpFinalScan-page.ts

db2305e

rgp kit upload - work in progress

ac2d1e3

added fs-extra in an attempt to get file location recognized

f20dc8b

WIP

b1962b3

WIP

5ee26be

Merge branch 'develop' into rgp_dsm_playwright_tests

4ad5bd7

aweng98 reviewed Jun 5, 2023

View reviewed changes

Rinchan20 added 8 commits June 7, 2023 10:22

WIP

89beaed

changes to get most recent playwright participant

ee60525

update tests to use new method for getting guids

fe0d7a2

Merge branch 'develop' into rgp_dsm_playwright_tests

5a22e4f

some changes after some tests failed in docker

7cec3b9

the @proband annotation is temporary while cleaning up tests

some cleanup and adding results of screenshot comparison

4642393

Rinchan20 mentioned this pull request Jun 8, 2023

Part 1 of Pepper-587 broken down to small PRs #2127

Merged

Rinchan20 mentioned this pull request Jul 14, 2023

add automation of the RGP proband tab #2160

Merged

Rinchan20 closed this Aug 15, 2023


		test.describe('Adult Self Enrollment', () => {
		test.describe.serial('Adult Self Enrollment', () => {

PEPPER-587: RGP DSM playwright tests_assert creation of new participant by checking DSM #2048

PEPPER-587: RGP DSM playwright tests_assert creation of new participant by checking DSM #2048

Uh oh!

Conversation

Rinchan20 commented Mar 2, 2023

Uh oh!

Rinchan20 commented Mar 2, 2023

Uh oh!

GiCharkviani Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GiCharkviani Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aweng98 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rinchan20 commented May 19, 2023

Uh oh!

Rinchan20 commented May 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rinchan20 commented Jun 12, 2023

Uh oh!

Rinchan20 commented Aug 15, 2023

Uh oh!

Rinchan20 commented Aug 15, 2023

Uh oh!

Uh oh!

GiCharkviani Mar 3, 2023 •

edited

Loading

GiCharkviani Mar 3, 2023 •

edited

Loading