Skip to content

refactor: add comments to generated Android code #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 18, 2021

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Sep 18, 2019

in order to achieve the twin benefits of cleaner generated code and cleaner template source code

with some TODO items:

  • similar improvement for other artifacts - moved into separate PRs
  • check that generated modules with generated examples continue to build and run on Android & iOS

(for Android only, at this point)
@brody4hire brody4hire self-assigned this Sep 18, 2019
@brody4hire brody4hire changed the base branch from dev to master November 15, 2019 05:36
@brody4hire brody4hire changed the title [..] add comments to beginning of generated artifacts [TBD] add comments to beginning of generated artifacts - Android only - DRAFT WIP Feb 11, 2021
@brody4hire
Copy link
Owner Author

brody4hire commented Feb 11, 2021

Due to the number of changes over the past year I will likely may start again, in a new PR.

@brody4hire brody4hire changed the title [TBD] add comments to beginning of generated artifacts - Android only - DRAFT WIP [TBD ...] add comments to beginning of generated artifacts - Android only (...) Feb 11, 2021
@brody4hire brody4hire changed the title [TBD ...] add comments to beginning of generated artifacts - Android only (...) refactor: add comments to generated Android code Feb 12, 2021
@brody4hire brody4hire marked this pull request as ready for review February 18, 2021 04:32
@brody4hire brody4hire merged commit 310194c into master Feb 18, 2021
@brody4hire brody4hire deleted the add-comments-to-beginning-of-artifacts branch February 18, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant