cleanup generated android/build.gradle artifact #138
Conversation
Co-authored-by: Frieder Bluemle <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Frieder Bluemle <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
| @@ -54,7 +53,8 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation "com.facebook.react:react-native:\${safeExtGet('reactnativeVersion', '+')}" | |||
| //noinspection GradleDynamicVersion | |||
| implementation 'com.facebook.react:react-native:+' // From node_modules | |||
There was a problem hiding this comment.
| implementation 'com.facebook.react:react-native:+' // From node_modules | |
| implementation 'com.facebook.react:react-native:+' // from node_modules |
There was a problem hiding this comment.
This comment is directly taken from the default template of react-native. Instead of customizing it here, it might be better to keep it in sync. If you think lower-casing is better, should we open a PR on react-native?
There was a problem hiding this comment.
There was a problem hiding this comment.
Instead of customizing it here, it might be better to keep it in sync.
+1, keeping in sync for now, at least
If you think lower-casing is better, should we open a PR on react-native?
+1 (I will deal with this sometime later)
I did push another change to add a reference to the Facebook template source, on stable branch for 0.60.
There was a problem hiding this comment.
Since this is your project, it's really up to you how much you want these boilerplate files to diverge from the official template. :) It's good to merge, please go ahead, so I can rebase #135 - I'll be on a flight and unavailable later today ;)
| @@ -86,7 +86,6 @@ def configureReactNativePom(def pom) { | |||
| } | |||
|
|
|||
| afterEvaluate { project -> | |||
|
|
|||
There was a problem hiding this comment.
comments would be nice in this afterEvaluate block, which I don't really understand at this point
There was a problem hiding this comment.
It is related to the different phases of Gradle. The execution phase starts after the configuration phase, and this afterEvaluate block will run in between. Read more here: https://www.oreilly.com/library/view/gradle-beyond-the/9781449373801/ch03.html
There was a problem hiding this comment.
Looks good to me. You can merge this first, then I'll rebase #135
Co-authored-by: Frieder Bluemle <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
brody4hire
changed the title
|
I just added some comments with links for reference, for the benefit to people like me, will merge once the build is green. |
as originally proposed in PR #135 by @friederbluemle