[tbd ???] update Android build tools Gradle classpath #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
changed the title
* update to `com.android.tools.build:gradle:3.5.0` * update comments Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Frieder Bluemle <[email protected]>
brody4hire
force-pushed
the
android-tools-build-gradle-classpath
branch
from
7b7624a to
8da93fd
Compare
|
Status:
keeping in draft state for now |
brody4hire
commented
Feb 9, 2021
Comment on lines
+20
to
+22
| // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15 | ||
| // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google | ||
| classpath 'com.android.tools.build:gradle:3.5.0' |
There was a problem hiding this comment.
brody4hire
commented
Feb 10, 2021
There was a problem hiding this comment.
As I said in the comments in PR #404 I think the classpath should be consistent with the minimum supported react-native version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.android.tools.build:gradle:3.5.0remove the uselesssafeExtGetcallas was originally proposed by @friederbluemle in pr #135
motivation: I would like to keep this change in a separate PR, to land in a separate commit, if possible