Skip to content

Add debug type for Module Namespace #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2021
Merged

Conversation

BickfordA
Copy link
Contributor

I have been setting up the debugger from https://github.com/Microsoft/ChakraCore-Debugger and was having trouble debugging modules, as the debugger would crash when reading the type attibute (as it didn't have one). Seems like that case never got added here.

@rhuanjl
Copy link
Collaborator

rhuanjl commented May 20, 2021

Thanks for the contribution @BickfordA please could you:

  1. Sign our contribution agreement by adding your name and github userID to this file:
    https://github.com/chakra-core/ChakraCore/blob/master/ContributionAgreement.md

  2. Update the copyright at the top of the file you've changed to:

//-------------------------------------------------------------------------------------------------------
// Copyright (C) Microsoft. All rights reserved.
// Copyright (c) 2021 ChakraCore Project Contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
//-------------------------------------------------------------------------------------------------------

BickfordA added 2 commits May 25, 2021 08:13
Add name to contribution agreement
Update copyright notice
@BickfordA
Copy link
Contributor Author

Alright, I think those two issues should be squared away.

@rhuanjl
Copy link
Collaborator

rhuanjl commented May 25, 2021

Looks good to merge except for the merge conflict (someone else signed the contribution agreement) - please could you update to latest master to fix?

@rhuanjl rhuanjl merged commit 385409e into chakra-core:master May 28, 2021
@rhuanjl
Copy link
Collaborator

rhuanjl commented May 28, 2021

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants