Skip to content

Add debug type for Module Namespace #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2021
Merged

Add debug type for Module Namespace #6718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c972e4
Add dubug type for Module Namespace
BickfordA May 19, 2021
1636064
Update ContributionAgreement.md
BickfordA May 25, 2021
1b93577
Update JsrtDebugUtils.cpp
BickfordA May 25, 2021
60ce483
Merge lastest changes
May 27, 2021
271a403
Merge branch 'chakra-core-master'
May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ContributionAgreement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,4 @@ This agreement has been signed by:
|Evgeniy Istomin|MadProbe|
|Wenlu Wang| Kingwl|
|Kevin Cadieux|kevcadieux|
|Aidan Bickford| BickfordA|
6 changes: 6 additions & 0 deletions lib/Jsrt/JsrtDebugUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//-------------------------------------------------------------------------------------------------------
// Copyright (C) Microsoft. All rights reserved.
// Copyright (c) 2021 ChakraCore Project Contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
//-------------------------------------------------------------------------------------------------------

Expand Down Expand Up @@ -215,6 +216,11 @@ void JsrtDebugUtils::AddPropertyType(Js::DynamicObject * object, Js::IDiagObject
addDisplay = true;
break;

case Js::TypeIds_ModuleNamespace:
JsrtDebugUtils::AddPropertyToObject(object, JsrtDebugPropertyId::type, scriptContext->GetLibrary()->GetModuleTypeDisplayString(), scriptContext);
addDisplay = true;
break;

case Js::TypeIds_Enumerator:
case Js::TypeIds_HostDispatch:
case Js::TypeIds_UnscopablesWrapperObject:
Expand Down