Skip to content

[Fix #537] Fail early in cljr-rename-symbol if narrowing is in effect #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Fix #537] Fail early in cljr-rename-symbol if narrowing is in effect #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30cad31
[Fix #537] Fail early in cljr-rename-symbol if narrowing is in effect
Jan 17, 2023
456b8aa
[Fix #537] Use "when" instead of "if"
Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- [#537](https://github.com/clojure-emacs/clj-refactor.el/issues/537): Fail early in `cljr-rename-symbol` in case narrowing is in effect.

## 3.6.1

- Add the [clojure.math namespace](https://clojure.github.io/clojure/clojure.math-api.html) to magic requires (new with Clojure 1.11.0)
Expand Down
1 change: 1 addition & 0 deletions clj-refactor.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2827,6 +2827,7 @@ See: https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-find-usages"

See: https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-rename-symbol"
(interactive)
(when (buffer-narrowed-p) (error "Cannot rename symbols while narrowing is in effect"))
(cljr--ensure-op-supported "find-symbol")
(when (cljr--asts-y-or-n-p)
(save-buffer)
Expand Down