Skip to content

Modify CCRenderTexture::end() default behaviour #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2012
Merged

Modify CCRenderTexture::end() default behaviour #828

merged 1 commit into from
Apr 13, 2012

Conversation

folecr
Copy link
Contributor

@folecr folecr commented Apr 6, 2012

  • Android port may cache textures.
  • This is set to true by default.
  • Should be false so that behaviour is the same between Android and other platforms that don't have this feature.

NOTE : This feature has performance problems on some devices so the default behaviour is even more critical. Needs to be investigated in future.

* Android port may cache textures.
* This is set to true by default.
* Should be false so that behaviour is the same between Android and other platforms that don't have this feature.

NOTE : This feature has performance problems on some devices so the default behaviour is even more critical. Needs to be investigated in future.
@folecr
Copy link
Contributor Author

folecr commented Apr 6, 2012

Test

  • RenderTextureSave calls end()
  • RenderTextureTest calls end(false)

On Android devices...

Before these changes

  • RenderTextureSave is much slower than RenderTextureTest

After these changes

  • RenderTextureSave and RenderTextureTest are the same speed

@minggo
Copy link
Contributor

minggo commented Apr 9, 2012

Thank you.
I will test corresponding test.

@folecr
Copy link
Contributor Author

folecr commented Apr 12, 2012

Looks OK?

@minggo
Copy link
Contributor

minggo commented Apr 13, 2012

Sorry, I am busy for developing cocos2d-x gles20 these days.
So I haven't tested.

I will test is ASAP.
Thank you again.

minggo pushed a commit that referenced this pull request Apr 13, 2012
fixed #161: Modify CCRenderTexture::end() default behaviour
@minggo minggo merged commit 7793cb1 into cocos2d:master Apr 13, 2012
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
fixed cocos2d#161: Modify CCRenderTexture::end() default behaviour
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
fixed cocos2d#161: Modify CCRenderTexture::end() default behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants