Fix #90 - booleans in subnet module aren't working #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camelize key with no uppercase first letter.
|
@Swaeltjie this PR should /fix #90. Can you please confirm that it meets your needs? |
|
@cmeissner Thank you, exactly what i was looking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter names that do not have a
phpipam_nameparameter where camelized.inflection.camelized()start strings by default with a uppercase letter. This behavior needs to be adapted as camelized parameters in API calls often start with lowercase letter.We also add a extra test step into the subnet test case