Skip to content

Fix #90 - booleans in subnet module aren't working #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- fix \#90 - booleans in subnet module aren't working
2 changes: 1 addition & 1 deletion plugins/module_utils/phpipam_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def _phpipam_spec_helper(self, spec):
ansible_invisible = value.get('invisible', False)

if 'phpipam_name' not in phpipam_value and '_' in key:
phpipam_value['phpipam_name'] = inflection.camelize(key)
phpipam_value['phpipam_name'] = inflection.camelize(key, uppercase_first_letter=False)

if phpipam_type == 'entity':
argument_value['type'] = 'str'
Expand Down
15 changes: 15 additions & 0 deletions tests/test_playbooks/subnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,21 @@
name: create subnet again, no change
subnet: "{{ base_subnet_data }}"

- name: set booleans
include: tasks/subnet.yml
vars:
name: set booleans
override:
show_as_name: Yes
dns_recursive: Yes
dns_records: Yes
allow_requests: Yes
ping_subnet: Yes
discover_subnet: Yes
is_folder: No
is_full: No
subnet: "{{ base_subnet_data | combine(override) }}"

- name: delete subnet
include: tasks/subnet.yml
vars:
Expand Down