Skip to content

feat: [FileCollection] add function to retain multiple patterns #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

christianberkman
Copy link
Contributor

@christianberkman christianberkman commented Jun 10, 2024

Description
Supersedes #8940

Add a method to FileCollection that accepts an array of strings to retain multiple patterns in the file collection.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.6 enhancement PRs that improve existing functionalities labels Jun 12, 2024
@kenjis
Copy link
Member

kenjis commented Jun 12, 2024

PHPStan and Rector checks in GitHub Actions failed.
Please fix them.

@kenjis kenjis changed the title feat: FileCollection: add function to retain multiple patterns feat: [FileCollection] add function to retain multiple patterns Jun 12, 2024
@kenjis
Copy link
Member

kenjis commented Jun 12, 2024

@christianberkman You are using the PR branch name 4.6.
It is a bad practice. I cannot checkout your PR branch with gh pr checkout 8953 command, because 4.6 is the branch name already used in this main repository.
Please name another branch name like feat-something in the future.

@christianberkman
Copy link
Contributor Author

My apologies and thank you for the clarification. Is there any use in renaming the branch now or do I start another PR with the renamed branch? Three times is the charm...

@christianberkman christianberkman deleted the branch codeigniter4:4.6 June 12, 2024 09:34
@christianberkman christianberkman deleted the 4.6 branch June 12, 2024 09:34
@@ -108,6 +108,8 @@ Model
Libraries
=========

- Added `retainMultiplePatterns()` to `FileCollection` class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the section retainMultiplePatterns in the page file_collections.rst?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/documentation.rst#to-a-section

@kenjis
Copy link
Member

kenjis commented Jun 12, 2024

There is no way to change the PR branch name.
Feel free to send another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants