-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: [FileCollection] add function to retain multiple patterns #8953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
PHPStan and Rector checks in GitHub Actions failed. |
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Co-authored-by: kenjis <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
@christianberkman You are using the PR branch name |
My apologies and thank you for the clarification. Is there any use in renaming the branch now or do I start another PR with the renamed branch? Three times is the charm... |
@@ -108,6 +108,8 @@ Model | |||
Libraries | |||
========= | |||
|
|||
- Added `retainMultiplePatterns()` to `FileCollection` class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the section retainMultiplePatterns
in the page file_collections.rst
?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/documentation.rst#to-a-section
There is no way to change the PR branch name. |
Description
Supersedes #8940
Add a method to
FileCollection
that accepts an array of strings to retain multiple patterns in the file collection.Checklist: