-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: [FileCollection] add function to reatain multiple patterns #8960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kenjis
merged 13 commits into
codeigniter4:4.6
from
christianberkman:feat-retain-multiple-patterns
Jun 15, 2024
Merged
feat: [FileCollection] add function to reatain multiple patterns #8960
kenjis
merged 13 commits into
codeigniter4:4.6
from
christianberkman:feat-retain-multiple-patterns
Jun 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Co-authored-by: kenjis <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
Signed-off-by: Christian Berkman <[email protected]>
kenjis
reviewed
Jun 12, 2024
Signed-off-by: Christian Berkman <[email protected]>
kenjis
reviewed
Jun 12, 2024
kenjis
reviewed
Jun 12, 2024
Co-authored-by: kenjis <[email protected]>
Co-authored-by: kenjis <[email protected]>
kenjis
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Thanks. I assume adding a similar function for |
michalsn
reviewed
Jun 12, 2024
Co-authored-by: Michal Sniatala <[email protected]>
kenjis
approved these changes
Jun 13, 2024
michalsn
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8953
Add a method to
FileCollection
that accepts an array of strings to retain multiple patterns in the file collection.Checklist: