CommonsApplication migrate to kotlin & some lint fixes

[parneet-guraya]

From comment

What changes did you make and why?

• Migrate application class to kotlin
• some lint fixes

Tests performed (required)

tested betaDebug & prodDebug on Oneplus 9RT 5G , Android 14

[parneet-guraya]

CI failing due to some unit test. Will fix it

[nicolas-raoul]

I did a few uploads and tried most activities of the app with this branch. It works as usual. :-)

[parneet-guraya]

Actually just one test failing due to lateinit instance property in application class, not being initialised while other tests do use that property and works fine :( . I'm a little rusty on testing, I will figure out what's causing this.

[parneet-guraya]

This test was causing the issue ThanksClientTest

apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/actions/ThanksClientTest.kt

Line 42 in f1205c1

`when`(CommonsApplication.getInstance()).thenReturn(commonsApplication)

when() started raising error that it needs a call to a method on mocked instance. Now, in this case we were calling instance on static, CommonsApplication.getInstance() was working fine when the class was in java but not when converted to kotlin. I'm guessing it's due to how to kotlin generate java impl internally such as it by default make properties final (I tried using open keyword` though).

Most likely this is library issue. Also, from my research on stackoverflow mocking statics is discouraged. Also I found out mockito mockk supports kotlin by design didn't try it though.

So, at the end I refactored the function to take application as an argument rather calling it inside.
Commit: d665188

[nicolas-raoul]

Thanks! Would you mind fixing the conflict?

[parneet-guraya]

Done

[parneet-guraya]

Waiting for this one #5887

[parneet-guraya]

Now that we have #5887 , this one's finally good to go. Give it a look whenever you can. I will have #5698 solution up after this.

[nicolas-raoul]

Thanks a lot! :-)