Skip to content

CommonsApplication migrate to kotlin & some lint fixes #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 26, 2024
Merged

CommonsApplication migrate to kotlin & some lint fixes #5879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d85a426
convert to kotlin
parneet-guraya Oct 20, 2024
8d629b4
use lateinit instead of nullable types
parneet-guraya Oct 20, 2024
f26b651
instance property access fix
parneet-guraya Oct 20, 2024
d957f21
refactor constants name with uppercased ones
parneet-guraya Oct 20, 2024
e470dad
remove unused
parneet-guraya Oct 20, 2024
ae49ba4
fix imports in test
parneet-guraya Oct 20, 2024
72398f4
use mockk for kotlin to fix tests
parneet-guraya Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/androidTest/java/fr/free/nrw/commons/AboutActivityTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class AboutActivityTest {
fun testLaunchTranslate() {
Espresso.onView(ViewMatchers.withId(R.id.about_translate)).perform(ViewActions.click())
Espresso.onView(ViewMatchers.withId(android.R.id.button1)).perform(ViewActions.click())
val langCode = CommonsApplication.getInstance().languageLookUpTable.codes[0]
val langCode = CommonsApplication.instance.languageLookUpTable!!.codes[0]
Intents.intended(
CoreMatchers.allOf(
IntentMatchers.hasAction(Intent.ACTION_VIEW),
Expand Down
Loading
Loading