Simplify credentials from 8 to 4 #200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdef
reviewed
Feb 22, 2018
csi.proto
Outdated
| // passing through the required credentials. This information is | ||
| // sensitive and MUST be treated as such (not logged, etc.) by the CO. | ||
| // Secrets required by plugin to complete controller unpublish volume | ||
| // request. This should be the same secrets passed to the |
csi.proto
Outdated
| // A secret is a string to string map where the key identifies the | ||
| // name of the secret (e.g. "username" or "password"), and the value | ||
| // contains the secret data (e.g. "bob" or "abc123"). | ||
| // Each key must consist of alphanumeric characters, '-', '_' or '.'. |
There was a problem hiding this comment.
nit: s/must/MUST/ (here and throughout changeset)
spec.md
Outdated
| @@ -1636,7 +1631,7 @@ Supervised plugins MAY be isolated and/or resource-bounded. | |||
| * Logging configuration flags and/or variables, including working sample configurations. | |||
| * Default log destination(s) (where do the logs go if no configuration is specified?) | |||
| * Log lifecycle management ownership and related guidance (size limits, rate limits, rolling, archiving, expunging, etc.) applicable to the logging mechanism embedded within the Plugin. | |||
| * Plugins SHOULD NOT write potentially sensitive data to logs (e.g. `Credentials`). | |||
| * Plugins SHOULD NOT write potentially sensitive data to logs (e.g. `Secrets`). | |||
There was a problem hiding this comment.
nit: there are no types or fields called Secrets. maybe just replace "Secrets" with "secrets"?
saad-ali
force-pushed
the
simplifyCreds2
branch
from
5ee1992 to
1a3affd
Compare
saad-ali
force-pushed
the
simplifyCreds2
branch
from
1a3affd to
b5dd57d
Compare
|
Feedback addressed. PTAL |
|
Conclusion on today's call was folks prefer #201 over this. So I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
provisioner_secretsCreateVolume()andDeleteVolume().controller_publish_secretsControllerPublishVolume()andControllerUnpublishVolume()node_stage_secretsNodeStageVolume()only.NodeUnstageVolume()which we can consider adding in the future, if needed.node_publish_secretsNodePublishVolume()onlyNodeUnpublishVolume()which we can consider adding in the future, if needed.