Clarify wording and naming of credentials in CSI #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
suggested changes
Feb 23, 2018
csi.proto
Outdated
| // An SP SHALL advertise the requirements for required secret keys and | ||
| // values in documentation. | ||
| // CO SHALL permit passing through the required secrets. CO MAY expose | ||
| // secrets as a one or more map to its end users, therefore the keys |
There was a problem hiding this comment.
This wording is a bit funky to me.
What about something like this (assuming I'm understanding what's written):
A CO MAY send the same secrets to all RPCs, therefore the keys for all unique secrets that an SP expects must be unique across.
saad-ali
force-pushed
the
simplifyCreds4
branch
from
6610693 to
daf30c4
Compare
|
@cpuguy83 Reworded. PTAL |
saad-ali
force-pushed
the
simplifyCreds4
branch
from
daf30c4 to
43e03b6
Compare
|
Wording looks good, but looks like the old wording is still underneath.
|
saad-ali
force-pushed
the
simplifyCreds4
branch
from
43e03b6 to
f4418ed
Compare
|
Whoops fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Alternate to #200
This PR: