Fix nerdctl load stdin for pipes. #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
force-pushed
the
fix-stdin
branch
3 times, most recently
from
a7f6f17 to
7f1a554
Compare
AkihiroSuda
reviewed
Oct 3, 2022
AkihiroSuda
reviewed
Oct 3, 2022
fahedouch
reviewed
Oct 3, 2022
manugupt1
force-pushed
the
fix-stdin
branch
3 times, most recently
from
b4ea021 to
d8c75dc
Compare
manugupt1
commented
Oct 4, 2022
| @@ -132,7 +132,7 @@ func loadImage(in io.Reader, cmd *cobra.Command, platMC platforms.MatchComparer, | |||
| if quiet { | |||
| fmt.Fprintln(cmd.OutOrStdout(), img.Target.Digest) | |||
| } else { | |||
| fmt.Fprintf(cmd.OutOrStdout(), "done\n") | |||
| fmt.Fprintf(cmd.OutOrStdout(), "Loaded image: %s", img.Name) | |||
There was a problem hiding this comment.
Makes the test docker compatible.
If stdin is received from a pipe, the size is still zero and an error will not be not thrown now. If stdin is empty, error will still be thrown. Added tests Signed-off-by: Manu Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1404