follow-up TestLoadStdinFromPipe #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @manugupt1 |
fahedouch
force-pushed
the
follow-up-fix-stdin
branch
from
2ea33a1 to
e927da7
Compare
Signed-off-by: fahed dorgaa <[email protected]>
fahedouch
force-pushed
the
follow-up-fix-stdin
branch
from
e927da7 to
ea90e56
Compare
manugupt1
approved these changes
Oct 4, 2022
| base := testutil.NewBase(t) | ||
|
|
||
| tmp := t.TempDir() | ||
| base.Cmd("pull", testutil.CommonImage).AssertOK() | ||
| base.Cmd("save", testutil.CommonImage, "-o", filepath.Join(tmp, "common.tar")).AssertOK() | ||
|
|
||
| base.Cmd("rmi", testutil.CommonImage).AssertOK() |
There was a problem hiding this comment.
I did not remove the image since it was named common image and did not want to slow down CI. I am not sure of the intention of why it was named like this. But LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #1405
For the consistency of the
TestLoadStdinFromPipetest, the image should be removed after saving it.Signed-off-by: fahed dorgaa [email protected]