Skip to content

[CI]: workaround gomodjail concurrency issue #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

apostasie
Copy link
Contributor

This adds a preflight call to nerdctl.gomodjail that will ensure extraction is done before we test, (hopefully) avoiding concurrency issues.

This is a workaround for AkihiroSuda/gomodjail#50 meant to reduce the disruptive effect on nerdctl CI, and must be removed once fixed upstream.

@apostasie apostasie changed the title Workaround gomodjail concurrency issue [CI]: workaround gomodjail concurrency issue May 6, 2025
@apostasie apostasie marked this pull request as draft May 6, 2025 16:44
@apostasie apostasie force-pushed the 2025-05-workaround-gmj branch from a805f94 to 4039cfe Compare May 6, 2025 16:56
@apostasie
Copy link
Contributor Author

Failures are:

  • CNIEnv concurrency issues #3556
  • windows is (now) getting over 3 seconds for rm tests (in TestRunRmTime) - this is likely a consequence of upgrading from containerd 1.7 to 2.0 - we probably just want to push the timeout from 3 seconds to 10 seconds (maybe only for windows)

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 998d139 into containerd:main May 7, 2025
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants