fix: nerdctl ps filter --status=created #4196

Shubhranshu153 · 2025-05-05T23:12:50Z

Issue:

sudo nerdctl ps -a --filter status=created
INFO[0000] containers %v[0xc0000e2000 0xc0000e20e0 0xc0000e21c0 0xc0000e22a0 0xc0000e2380 0xc0000e2460 0xc0000e2540 0xc0000e2620 0xc0000e2700] 
INFO[0000] filters %v[0xc0000e2000 0xc0000e20e0 0xc0000e21c0 0xc0000e22a0 0xc0000e2380 0xc0000e2460 0xc0000e2540 0xc0000e2620 0xc0000e2700] 
WARN[0000] no running task found: task 53fac80968c8b2f86a12bd5b8e99a043b80f5a7b2287b1e4e4db66f968a905ee not found 
WARN[0000] no running task found: task a250bf16efad4a9c2db89e82d76cdee1a466492d50a3411aa3da4276e1bc4ea8 not found 
WARN[0000] no running task found: task dc1e36498cefa97d40e9bdfea044365e836f9e711e24807b221dc64cbed34a48 not found 
WARN[0000] no running task found: task e97a33181bf251204fbb476ae10945e09269a01a938fcd861a1a14c31ca993c4 not found 
WARN[0000] no running task found: task eedd262ef9933cad2d04579355dd64287e46b948a997d90329f71888c882a24a not found 
INFO[0000] matches %v[]                                 
CONTAINER ID    IMAGE    COMMAND    CREATED    STATUS    PORTS    NAMES

Fix:

INFO[0000] contianer created                            
CONTAINER ID    IMAGE                                   COMMAND                   CREATED              STATUS     PORTS                                               NAMES
eedd262ef993    docker.io/library/alpine:latest         "/bin/sh"                 About an hour ago    Created                                                        test1
dc1e36498cef    docker.io/jenkins/jenkins:lts-jdk17     "/usr/bin/tini -- /u…"    6 hours ago          Created    0.0.0.0:8088->8080/tcp, 0.0.0.0:50000->50000/tcp    jenkins-dc1e3
a250bf16efad    docker.io/jenkins/jenkins:lts-jdk17     "/usr/bin/tini -- /u…"    6 hours ago          Created    0.0.0.0:8088->8080/tcp, 0.0.0.0:50000->50000/tcp    jenkins-a250b
e97a33181bf2    docker.io/jenkins/jenkins:lts-jdk17     "/usr/bin/tini -- /u…"    6 hours ago          Created    0.0.0.0:8088->8080/tcp, 0.0.0.0:50000->50000/tcp    jenkins-e97a3
53fac80968c8    docker.io/portainer/portainer:latest    "/portainer"              2 days ago           Created    0.0.0.0:9000->9000/tcp                              portainer-53fac
[shubhum@lima-finch nerdctl]$ sudo nerdctl ps -a --filter status=created --filter name=test1
INFO[0000] checking                                     
INFO[0000] contianer created

Shubhranshu153 · 2025-05-05T23:14:51Z

@apostasie
While solving for create issue found this issue as i wanted to use this filter status=created, pushing this fix out first.

Shubhranshu153 · 2025-05-06T05:01:21Z

@AkihiroSuda @apostasie
this fixes:

[CI]: failure nerdctl - TestCreate/logs appears to be flaky #3717
status=created filter

Seems CI/CD is somewhat stable, the gomodjail i dont understand atm.

Shubhranshu153 · 2025-05-06T05:03:11Z

The logs after start with -a seems to not get handled correctly so changed the test as it was testing the create functionality.

pkg/cmd/container/list.go

apostasie · 2025-05-06T16:00:02Z

@AkihiroSuda @apostasie this fixes:

[CI]: failure nerdctl - TestCreate/logs appears to be flaky #3717

status=created filter

Seems CI/CD is somewhat stable, the gomodjail i dont understand atm.

Thanks a lot for engaging with these @Shubhranshu153 - really appreciated.

Gomodjail issue is likely AkihiroSuda/gomodjail#50 - gomodjail does self-unpack (the actual executable and go.mod), but this is not currently done in a safe way (needs to use flock to prevent concurrent access).

On your last run, I see an unrelated rekor error, some windows non-sense - and the event filter issue.

I think we should have this patch here asap (cc @AkihiroSuda).

AkihiroSuda · 2025-05-06T16:01:41Z

The current CI failures do not seem related to gomodjail

apostasie · 2025-05-06T16:40:56Z

The current CI failures do not seem related to gomodjail

They are not on the last run (they are a rekor issue, windows, and the event one on EL)

Shubhranshu153 · 2025-05-06T17:19:47Z

@AkihiroSuda @apostasie Refactored the events test a bit lets see

apostasie · 2025-05-06T17:55:36Z

cmd/nerdctl/container/container_create_test.go

@@ -47,23 +48,16 @@ func TestCreate(t *testing.T) {
 		{


@Shubhranshu153 we should remove testCase.Require = nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3717") just above.

yes we should i want to see it a few more runs and would remove
I still think gomodjail has issues. and is flaky.

Commit 4 in this PR should workaround gomodjail unpack issue: #4199

@Shubhranshu153 so, the presence of testCase.Require = nerdtest.IsFlaky will make it automatically retry in case of failure, which will "hide" them... What I am suggesting is that we remove it now so that you get accurate feedback from the CI on whether this is fixed or not.

Sorry, wrong PR linked. gomodjail workaround is here: #4198

The other (wrongly) mentioned PR would alleviate the Windows failure you are hitting on your last run.

yeah i got confused as it seems unrelated.

Great, lot of good fixes are going in to make the CI more resiliant.
have few PR's approved but pending successful runs so would like the fixes in to have a successful run.

Agreed!
And thanks again for engaging on that.

@AkihiroSuda pending green and review of course, it would be really nice to have #4198, #4199, and this here, at your convenience - that should reduce a good chunk of flakyness and frustration :-).

This looks good now.

Signed-off-by: Shubharanshu Mahapatra <[email protected]>

AkihiroSuda

Thanks

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch 2 times, most recently from 828ce70 to 31633cc Compare May 5, 2025 23:24

Shubhranshu153 changed the title ~~fix: test nerdctl ps filter~~ fix: nerdctl ps filter --status=created May 5, 2025

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch 5 times, most recently from ab81f1e to 58d90e5 Compare May 6, 2025 03:57

AkihiroSuda added this to the v2.1.0 milestone May 6, 2025

AkihiroSuda reviewed May 6, 2025

View reviewed changes

pkg/cmd/container/list.go Outdated Show resolved Hide resolved

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch 2 times, most recently from 2967ba5 to 1368b12 Compare May 6, 2025 13:22

Shubhranshu153 closed this May 6, 2025

Shubhranshu153 reopened this May 6, 2025

apostasie approved these changes May 6, 2025

View reviewed changes

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch from 1368b12 to 4b50d62 Compare May 6, 2025 17:19

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch from 4b50d62 to cf7781b Compare May 6, 2025 17:38

apostasie reviewed May 6, 2025

View reviewed changes

fix: test nerdctl ps filter created.

65f4412

Signed-off-by: Shubharanshu Mahapatra <[email protected]>

Shubhranshu153 force-pushed the fix-nerdctl-ps-filter branch from cf7781b to 65f4412 Compare May 6, 2025 18:03

This was referenced May 6, 2025

feat: add --no-stdin flag to container attach #4176

Merged

feat: add support for userns #3941

Merged

fix: logs updated on starting of a stopped container #3896

Merged

AkihiroSuda approved these changes May 7, 2025

View reviewed changes

AkihiroSuda merged commit 0cd6b6c into containerd:main May 7, 2025
37 checks passed

Shubhranshu153 deleted the fix-nerdctl-ps-filter branch May 7, 2025 17:47

Shubhranshu153 mentioned this pull request May 9, 2025

[CI]: failure nerdctl - TestCreate/logs appears to be flaky #3717

Closed

fix: nerdctl ps filter --status=created #4196

fix: nerdctl ps filter --status=created #4196

Uh oh!

Conversation

Shubhranshu153 commented May 5, 2025

Uh oh!

Shubhranshu153 commented May 5, 2025

Uh oh!

Shubhranshu153 commented May 6, 2025

Uh oh!

Shubhranshu153 commented May 6, 2025

Uh oh!

Uh oh!

apostasie commented May 6, 2025

Uh oh!

AkihiroSuda commented May 6, 2025

Uh oh!

apostasie commented May 6, 2025

Uh oh!

Shubhranshu153 commented May 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!