test: update test logic in TestTestParseFlagPWithPlatformSpec #4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test does not run in the rootfull Linux environment. Also, there are some cases where the test does not run. Therefore, this commit modifies all tests to perform the evaluation. Note that when the host ports are not specified in the -p option of `nerdctl run`, ports are randomly assigned, but it is not known what port number will be assigned in each test. Therefore, this commit modifies not to compare host ports. Signed-off-by: Hayato Kiwata <[email protected]>
|
Similar Case : #4260 |
|
Oh, tests failed ...
So, could maintainers retry the CI ? |
AkihiroSuda
reviewed
May 17, 2025
This was referenced May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test does not run in the rootfull Linux environment.
Also, there are some cases where the test does not run.
Therefore, this commit modifies all tests to perform the evaluation.
Note that when the host ports are not specified in the -p option of
nerdctl run, ports are randomly assigned, but it is not known what port number will be assigned in each test.Therefore, this commit modifies not to compare host ports.