Skip to content

test: refactor TestTestParseFlagPWithPlatformSpec and TestParsePortsL… #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

haytok
Copy link
Contributor

@haytok haytok commented May 18, 2025

…abel

@haytok
Copy link
Contributor Author

haytok commented May 18, 2025

ref: #4261 (comment)

@haytok
Copy link
Contributor Author

haytok commented May 18, 2025

Failures of lint has occured, so I'll lint my fix.

@haytok haytok force-pushed the refactor_portutil_test.go branch from 6d5f461 to 0365d39 Compare May 18, 2025 09:27
@haytok
Copy link
Contributor Author

haytok commented May 18, 2025

I got an unfamiliar error, but will take a look ...

ERROR: failed to solve: process "/bin/sh -c STARGZ_SNAPSHOTTER_VERSION=${STARGZ_SNAPSHOTTER_VERSION%%@*}; fname="stargz-snapshotter-${STARGZ_SNAPSHOTTER_VERSION}-${TARGETOS:-linux}-${TARGETARCH:-amd64}.tar.gz" && curl -o "${fname}" -fsSL --proto '=https' --tlsv1.2 "[https://github.com/containerd/stargz-snapshotter/releases/download/${STARGZ_SNAPSHOTTER_VERSION}/${fname}](https://github.com/containerd/stargz-snapshotter/releases/download/$%7BSTARGZ_SNAPSHOTTER_VERSION%7D/$%7Bfname%7D/)" && curl -o "stargz-snapshotter.service" -fsSL --proto '=https' --tlsv1.2 "[https://raw.githubusercontent.com/containerd/stargz-snapshotter/${STARGZ_SNAPSHOTTER_VERSION}/script/config/etc/systemd/system/stargz-snapshotter.service](https://raw.githubusercontent.com/containerd/stargz-snapshotter/$%7BSTARGZ_SNAPSHOTTER_VERSION%7D/script/config/etc/systemd/system/stargz-snapshotter.service/)" && grep "${fname}" "/SHA256SUMS.d/stargz-snapshotter-${STARGZ_SNAPSHOTTER_VERSION}" | sha256sum -c - && grep "stargz-snapshotter.service" "/SHA256SUMS.d/stargz-snapshotter-${STARGZ_SNAPSHOTTER_VERSION}" | sha256sum -c - && tar xzf "${fname}" -C /out/bin && rm -f "${fname}" /out/bin/stargz-store && mv stargz-snapshotter.service /out/lib/systemd/system/stargz-snapshotter.service && echo "- Stargz Snapshotter: ${STARGZ_SNAPSHOTTER_VERSION}" >> /out/share/doc/nerdctl-full/README.md" did not complete successfully: exit code: 22

The step that tests have failed is below.

- name: "Compile binaries"
run: make artifacts

exit code is 22, so it is possible that curl failed.

curl -o "${fname}" -fsSL --proto '=https' --tlsv1.2 "https://github.com/containerd/stargz-snapshotter/releases/download/${STARGZ_SNAPSHOTTER_VERSION}/${fname}" && \

Looking at the log of the job, it is thought that linux was stored in TARGETOS and amd64 in TARGETARCH.
Therefore, stargz-snapshotter-v0.16.3-linux-amd64.tar.gz is considered to have been stored in fname.

This file exists at : https://github.com/containerd/stargz-snapshotter/releases/tag/v0.16.3

We are not sure why the curl error occurred because there are no detailed logs, and it is possible that a temporary network problem prevented the fname file from being downloaded.


Please let me know if I have analyzed it incorrectly 🙏

@apostasie
Copy link
Contributor

“curl: (22) The requested URL returned error: 429“

github is telling you that they are throttling us (“too many requests”).
This is a problem, and we have to address it, but this is not going to be simple…

@haytok
Copy link
Contributor Author

haytok commented May 18, 2025

Thanks for the comment!
So we'll just have to give it some time and retries have to be done by maintainers ....

@apostasie
Copy link
Contributor

apostasie commented May 18, 2025

Thanks for the comment! So we'll just have to give it some time and retries have to be done by maintainers ....

You can also just close/re-open the PR to trigger a CI re-run (or force-push).

@haytok
Copy link
Contributor Author

haytok commented May 18, 2025

Thanks !!!! I’ll try that :)

@apostasie
Copy link
Contributor

apostasie commented May 18, 2025

@haytok #4264 - #4265

@haytok haytok closed this May 19, 2025
@haytok haytok reopened this May 19, 2025
@haytok
Copy link
Contributor Author

haytok commented May 19, 2025

Thanks for your PR related this event!

The first time, errors occurred in the following.

I retried CI and the error in dependencies was resolved, but the error in release continued to occur because of the same issue.
So I think it is better to wait for the merge of the PR created by apostasie.

@AkihiroSuda AkihiroSuda added this to the v2.1.2 milestone May 20, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit f207d83 into containerd:main May 20, 2025
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants