Skip to content

[CI]: move away from raw github domain to API #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented May 18, 2025

Fix (part of?) #4264
See ^ for context.

TL;DR: recent changes in GitHub rate limits (presumably https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/) now break the build for us, apparently for requests to raw.githubusercontent.

This PR does a couple of things:

  • ensure we pass along the GITHUB_TOKEN into the Dockerfile so that we can authenticate GitHub queries
  • provide a helper that can retrieve (authenticated) raw content from GitHub API instead of using the raw domain

Note that it is unclear if we are going to get throttled on other GitHub requests as well - but at least we now have the infrastructure in place to perform authenticated requests, so, we can change what needs be later on piece-meal.

@apostasie apostasie force-pushed the 2025-05-github-raw-429 branch from a46b5e6 to 63d4340 Compare May 18, 2025 17:54
@apostasie apostasie closed this May 18, 2025
@apostasie apostasie reopened this May 18, 2025
@apostasie apostasie force-pushed the 2025-05-github-raw-429 branch from 63d4340 to 5b74fe9 Compare May 18, 2025 19:43
@apostasie apostasie changed the title [WIP] [CI]: move away from raw github domain to API [CI]: move away from raw github domain to API May 18, 2025
@apostasie apostasie marked this pull request as ready for review May 18, 2025 20:21
@apostasie
Copy link
Contributor Author

apostasie commented May 18, 2025

Failure is random logs failure.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apostasie apostasie force-pushed the 2025-05-github-raw-429 branch from 5b74fe9 to 9721413 Compare May 19, 2025 18:13
@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone May 20, 2025
@apostasie apostasie force-pushed the 2025-05-github-raw-429 branch 2 times, most recently from 3b7d403 to 8634a87 Compare May 20, 2025 17:15
@apostasie apostasie requested a review from AkihiroSuda May 20, 2025 17:15
@apostasie apostasie force-pushed the 2025-05-github-raw-429 branch from 8634a87 to 3b89195 Compare May 20, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants