Skip to content

support pull request suggestions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2bndy5 opened this issue Aug 17, 2024 · 0 comments · Fixed by #33
Closed

support pull request suggestions #9

2bndy5 opened this issue Aug 17, 2024 · 0 comments · Fixed by #33
Assignees
@2bndy5
Labels
enhancement New feature or request

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Aug 17, 2024

The pure python codebase already does this. So, we have a paradigm from which to follow or improve.

It would also be nice if we could stage the changes applied by a clang tool. See cpp-linter/cpp-linter#82 for the discussion about how to approach that.
@2bndy5 2bndy5 self-assigned this Aug 17, 2024
@2bndy5 2bndy5 mentioned this issue Aug 17, 2024
Closed
2bndy5 added a commit that referenced this issue Aug 26, 2024
@2bndy5
begin documenting permissions
b379920 
resolves #17

This is mostly copied and pasted from cpp-linter-action's corresponding doc.

The parts about PR reviews have been commented out and should be un-commented when addressing #9.
@2bndy5 2bndy5 mentioned this issue Aug 26, 2024
Merged
@2bndy5 2bndy5 added the enhancement New feature or request label Sep 9, 2024
@2bndy5 2bndy5 moved this from Todo to In progress in Rust feature parity with pure python project Sep 13, 2024
@2bndy5 2bndy5 mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2bndy5 2bndy5

Labels
enhancement New feature or request
Projects
Rust feature parity with pure python project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR review suggestions cpp-linter/cpp-linter-rs
1 participant
@2bndy5