-
-
Notifications
You must be signed in to change notification settings - Fork 0
PR review suggestions #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 97.32% 98.55% +1.23%
==========================================
Files 13 12 -1
Lines 2427 3046 +619
==========================================
+ Hits 2362 3002 +640
+ Misses 65 44 -21 ☔ View full report in Codecov by Sentry. |
57dd945
to
32a8394
Compare
This comment has been minimized.
This comment has been minimized.
744f28d
to
0217de1
Compare
reuse a local composite action to install clang tools clear added PPA for reuse of LLVM install script only run long-running unit tests on latest supported clang version
834e2d9
to
7a144b5
Compare
Exclude clang v7 and v8 on windows for PR review tests. Those versions do not have a consistent cross-platform output from clang-tidy.
I had to exclude testing clang versions 7 and 8 in Windows CI because the clang-tidy output is not consistent with the clang-tidy output (of the same versions) on Linux. This surfaced when making the tests for PR reviews very strict. I don't think this is a big deal because the latest MSVC compiler already complains that clang v16+ is expected (and we have been ignoring that advice). |
* exclude main.rs from coverage report to codecov * change dependabot checks to weekly * add test-clean recipe * add codecov config * post review comments * revamp test CI * add strictness to tests Exclude clang v7 and v8 on windows for PR review tests. Those versions do not have a consistent cross-platform output from clang-tidy.
Warning Rate limit exceeded@2bndy5 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 18 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
resolves #9