[Core] Replace TimeService with Java Time API #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating code to use Java 8 Time API for both Duration and Timestamps. Using Instant and Duration for all instances.
unused import
mleegwt
reviewed
May 4, 2019
mpkorstanje
reviewed
May 4, 2019
core/src/main/java/io/cucumber/core/api/event/TimeStampedEvent.java
Outdated
Show resolved
Hide resolved
Correct. I updated the time formatting to handle for values received from Duration and Instant instead |
I think that's because you no longer divide the nanos? |
Yes you're right. I had updated the formatter to use nanos directly so I updated the tests as well. But I am updating the format back to millis now and adding the division. |
mpkorstanje
reviewed
May 26, 2019
junit/src/test/java/io/cucumber/junit/api/FeatureRunnerTest.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
May 26, 2019
|
Looks pretty good so far! I'll need a bit more time to check the details. |
mpkorstanje
reviewed
May 26, 2019
core/src/test/java/io/cucumber/core/plugin/JUnitFormatterTest.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
May 30, 2019
mpkorstanje
changed the title
|
Looks all good. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrating the current code to use Java 8 Time API fields instead of the currently used primitive fields.
Details
The long fields
time,timeStampMillisanddurationhave been replaced byInstantandDurationrespectively.These values can now be used instead of older primitives to allow for better representation of time and duration in cucumber without having to worry about precision or granularity.
Motivation and Context
To allow for more consistent time measurements and reduce custom code.
How Has This Been Tested?
All the JUnits have been updated accordingly to use
InstantandDuration.Types of changes
Checklist: