-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[Core] Replace TimeService with Java Time API #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mpkorstanje
merged 11 commits into
cucumber:develop-v5
from
zutshiy:java8-timeapi-migration
May 30, 2019
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7de3b2b
Migration to Java 8 Time API
zutshiy c939ab9
Update CanonicalEventOrder.java
zutshiy 376a7d2
Deprecating older methods
zutshiy 86d037c
Replacing TimeService with Clock
zutshiy 8ec4e9c
Correcting imports
zutshiy 45dd1f7
Merge branch 'develop-v5' into java8-timeapi-migration
zutshiy b552869
Correcting imports
zutshiy 2f5a30f
Refractoring. Removing Deprecations
zutshiy ff27b89
Updating formatter
zutshiy 8629210
Revert nanos back to millis in JUnits
zutshiy 44b8396
Indentation
zutshiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
core/src/main/java/io/cucumber/core/api/event/TestCaseEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
core/src/main/java/io/cucumber/core/api/event/TestRunFinished.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,20 @@ | ||
package io.cucumber.core.api.event; | ||
|
||
import java.time.Instant; | ||
|
||
public final class TestRunFinished extends TimeStampedEvent { | ||
|
||
@Deprecated | ||
public TestRunFinished(Long timeStamp) { | ||
this(timeStamp, 0); | ||
} | ||
|
||
@Deprecated | ||
public TestRunFinished(Long timeStamp, long timeStampMillis) { | ||
super(timeStamp, timeStampMillis); | ||
} | ||
|
||
public TestRunFinished(Instant timeInstant) { | ||
super(timeInstant); | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
core/src/main/java/io/cucumber/core/api/event/TestRunStarted.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,20 @@ | ||
package io.cucumber.core.api.event; | ||
|
||
import java.time.Instant; | ||
|
||
public final class TestRunStarted extends TimeStampedEvent { | ||
|
||
@Deprecated | ||
public TestRunStarted(Long timeStamp) { | ||
this(timeStamp, 0); | ||
} | ||
|
||
@Deprecated | ||
public TestRunStarted(Long timeStamp, long timeStampMillis) { | ||
super(timeStamp, timeStampMillis); | ||
} | ||
|
||
public TestRunStarted(Instant timeInstant) { | ||
super(timeInstant); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.