-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[CDI2] Add CDI2 integration #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers. Looks pretty solid. Could you add a minimal read me that covers:
- Dependencies needed
- Which annotations (if any) should be used.
- Anything else needed to make https://github.com/cucumber/cucumber-java-skeleton work with CDI.
cdi2/pom.xml
Outdated
<dependencies> | ||
<dependency> | ||
<groupId>io.cucumber</groupId> | ||
<artifactId>cucumber-java</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just merged #1615. By implementing io.cucumber.core.backend.ObjectFactory
only a dependency on cucumber-core
is needed.
@@ -0,0 +1,4 @@ | |||
package cucumber.api.cdi2; | |||
|
|||
public class README { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
Looks like the build is failing on Java 11. This can be solved by adding a dependency on:
|
@mpkorstanje just pushed a commit, hopefully fixing all comments - and thanks a lot for the catches up! |
Hi @rmannibucau, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Cheers! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
1 similar comment
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi @rmannibucau, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Summary
OpenWebBeans PR looks outdated now CDI 2 has a dedicated API to manage a container.
Note it also unify weld module so it can likely be removed after some deprecation time.
To be complete the deltaspike module should stay a bit for CDI 1.x containers.
Details
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: