[OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans #971

rmannibucau · 2016-03-08T16:40:24Z

An alternative to Weld supporting already running container to smoothly integrate with OpenEJB if needed - and with the rule PR I did earlier.

Side note: the PR uses cucumber.api.openwebbeans.OpenWebBeansConfig as a SPI cause cucumber doesn't provide a "config scanning" out of the box but it would have been nice to have it as an annotation.

stale · 2018-02-12T00:07:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

rmannibucau · 2018-02-12T07:07:46Z

Still relevant

stale · 2018-04-13T07:28:56Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

stale · 2018-04-20T07:49:54Z

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

lock · 2019-04-20T08:30:44Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mpkorstanje

Heya, not sure how this was forgotten but the DeltaPike PR tickled my memory. Could you add a README.md to explain how this module should be used? It doesn't appear to be trivial.

I general the information included should be sufficient to get some one who's checked out the https://github.com/cucumber/cucumber-java-skeleton to get started.

So listing the required dependencies, the optional dependencies, and including an example of a step definition class that uses injection should be enough. Feel free to add anything else that is note worthy too.

mpkorstanje · 2019-05-05T13:43:25Z

openwebbeans/src/main/java/cucumber/runtime/java/openwebbeans/OpenWebBeansObjectFactory.java

+
+    @Override
+    public void stop() {
+        synchronized (contexts) {


stop will not be called concurrently. There should be no need to synchronize on contexts.

mpkorstanje · 2019-05-05T13:50:37Z

openwebbeans/src/main/java/cucumber/runtime/java/openwebbeans/OpenWebBeansObjectFactory.java

+        final CreationalContextImpl<Object> creationalContext = bm.createCreationalContext(null);
+        T created = type.cast(bm.getReference(bean, type, creationalContext));
+        if (!bm.isNormalScope(bean.getScope())) {
+            synchronized (contexts) {


Same here. getInstance will not be called concurrently.

mpkorstanje · 2019-05-05T13:52:51Z

openwebbeans/src/main/java/cucumber/api/openwebbeans/OpenWebBeansConfig.java

+package cucumber.api.openwebbeans;
+
+public interface OpenWebBeansConfig {
+    boolean userManaged();


I'm not happy about this. We currently don't have a good way to configure ObjectFactories. But that doesn't mean we should allow add-hoc configurations. I would prefer to keep this simple and working with sane defaults for now. If people want something more configurable they can implement their own version and deal with that complexity.

mpkorstanje · 2019-05-05T13:53:07Z

openwebbeans/pom.xml

+        <groupId>info.cukes</groupId>
+        <artifactId>cucumber-jvm</artifactId>
+        <relativePath>../pom.xml</relativePath>
+        <version>1.2.5-SNAPSHOT</version>


This probably needs an update. 😆

mpkorstanje · 2019-05-05T13:53:15Z

openwebbeans/pom.xml

+    <parent>
+        <groupId>info.cukes</groupId>
+        <artifactId>cucumber-jvm</artifactId>
+        <relativePath>../pom.xml</relativePath>


relativePath is not needed.

mpkorstanje · 2019-05-05T13:56:58Z

openwebbeans/pom.xml

+        <dependency>
+            <groupId>info.cukes</groupId>
+            <artifactId>cucumber-jvm-deps</artifactId>
+            <scope>provided</scope>


The dependency cucumber-jvm-deps is not needed.

mpkorstanje · 2019-05-05T13:57:03Z

openwebbeans/pom.xml

+        <dependency>
+            <groupId>info.cukes</groupId>
+            <artifactId>gherkin</artifactId>
+            <scope>provided</scope>


The dependency gherkin is not needed.

mpkorstanje · 2019-05-05T13:58:42Z

openwebbeans/pom.xml

+        <dependency>
+            <groupId>javax.enterprise</groupId>
+            <artifactId>cdi-api</artifactId>
+            <scope>provided</scope>


I've refactored the various POM files to reduce the coupling between modules. You'll have to provide a version for the CDI API here. For reference:

https://github.com/cucumber/cucumber-jvm/blob/master/weld/pom.xml

mpkorstanje · 2019-05-05T13:59:04Z

openwebbeans/pom.xml

+        <dependency>
+            <groupId>net.sourceforge.cobertura</groupId>
+            <artifactId>cobertura</artifactId>
+            <scope>test</scope>


Not needed.

mpkorstanje · 2019-05-05T13:59:58Z

...webbeans/src/test/java/cucumber/runtime/java/openwebbeans/OpenWebBeansObjectFactoryTest.java

@@ -0,0 +1,4 @@
+package cucumber.runtime.java.openwebbeans;
+
+public class OpenWebBeansObjectFactoryTest {


Empty class?

mpkorstanje · 2019-05-05T18:52:28Z

@rmannibucau do we still need this with #1616?

rmannibucau · 2019-05-05T19:02:14Z

@mpkorstanje yes and no. Since this PR CDI (v2) has a standard API for standalone apps (SeContainer) so this can be a portable replacement for openwebbeans and weld.

CdiCtrl of deltaspike was for before this time - which means that using deltaspike and CDI class explicitly is likely unintended.

Im fine closing the or if CDI Se API replaces it but i cant always use deltaspike in the testing stack - i want to control the boot api for cucumber.

mpkorstanje · 2019-05-05T19:15:21Z

CdiCtrl of deltaspike was for before this time - which means that using deltaspike and CDI class explicitly is likely unintended.

So you are saying that the implementation in #1616 is using CDI incorrectly? Could you put that comment in there. I don't know enough about the CDI ecosystem to make definitive statements.

Im fine closing the or if CDI Se API replaces it but i cant always use deltaspike in the testing stack - i want to control the boot api for cucumber.

Figured.

rmannibucau · 2019-05-05T19:17:46Z

Commented.

toepi · 2019-05-05T21:25:42Z

Sry to ask it her. But what do you want control until boot? Is CDIExtensions (https://docs.oracle.com/javaee/6/api/javax/enterprise/inject/spi/Extension.html) mechanism not enough?

rmannibucau · 2019-05-05T21:39:36Z

No for these cases:

Add steps as cdi beans without making them explicitly beans (guess an extension could almost do it but not 100% guaranteed),
Reuse started container for all tests (cucumber or not),
Test some toggling logic in libs between cdi se api, deltaspike and other modes (requires classpath to not contain org.apache.deltaspike or other packages depending executions)

So nothing strictly wrong with DS but some advanced usages requiring it to not be there.

toepi · 2019-05-06T16:50:40Z

for 1: Producer?

for 2: oh i thought i was the only one who need it. How do you solve it? I use scopes for it and think about it for the other pr - but unsure ....

mpkorstanje · 2019-05-06T17:28:33Z

I'm happy to take both PR's. While CDI containers are used only by a fraction of the users they're relatively low maintenance and have a relatively high number of contributors.

I do however have a rather limited knowledge of either so I'd like both implementations to be correct, in line with the frameworks expected use (so as to limit future questions/issues) and focused on the basic use case. For advanced use cases I expect that people re-implement the factory. At least until we come up with something better.

Also if you can both review and approve each others PR's then I can have some confidence that both implementations are good.

rmannibucau · 2019-05-06T18:29:18Z

@toepi

Extension or just not making them cdi beans but lazily injection target (i use last option generally since it covers more cases but hapoy with first one too)
Scope doesnt work since each runner will start/stop the container. In openwebbeans we use a static global instance and if set we dont re-set it. A shutdown hook closes it.

rmannibucau · 2019-05-10T09:31:16Z

closing as being superseeded by #1626

lock · 2020-05-20T21:41:10Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock · 2020-05-20T21:41:52Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

adding openwebbeans module

9d47d40

mpkorstanje added the ⚡ enhancement Request for new functionality label Jul 7, 2017

mpkorstanje force-pushed the master branch from ad3e012 to fdee635 Compare October 12, 2017 16:17

mpkorstanje force-pushed the master branch 9 times, most recently from 159ec4c to 74325ea Compare December 10, 2017 20:05

stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018

stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018

stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 13, 2018

stale bot closed this Apr 20, 2018

lock bot locked as resolved and limited conversation to collaborators Apr 20, 2019

cucumber unlocked this conversation May 5, 2019

mpkorstanje added the 🧷 pinned Tells Stalebot not to close this issue label May 5, 2019

mpkorstanje reopened this May 5, 2019

stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label May 5, 2019

mpkorstanje reviewed May 5, 2019

View reviewed changes

mpkorstanje changed the title ~~adding openwebbeans module~~ [OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans May 5, 2019

toepi mentioned this pull request May 5, 2019

[DeltaSpike] Add ObjectFactory for Apache DeltaSpike #1616

Merged

6 tasks

rmannibucau closed this May 10, 2019

lock bot locked as resolved and limited conversation to collaborators May 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans #971

[OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans #971

rmannibucau commented Mar 8, 2016

stale bot commented Feb 12, 2018

rmannibucau commented Feb 12, 2018

stale bot commented Apr 13, 2018

stale bot commented Apr 20, 2018

lock bot commented Apr 20, 2019

mpkorstanje left a comment

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019

mpkorstanje May 5, 2019

mpkorstanje commented May 5, 2019

rmannibucau commented May 5, 2019

mpkorstanje commented May 5, 2019

rmannibucau commented May 5, 2019

toepi commented May 5, 2019

rmannibucau commented May 5, 2019

toepi commented May 6, 2019

mpkorstanje commented May 6, 2019 •

edited

Loading

rmannibucau commented May 6, 2019

rmannibucau commented May 10, 2019

lock bot commented May 20, 2020

lock bot commented May 20, 2020

		@@ -0,0 +1,4 @@
		package cucumber.runtime.java.openwebbeans;

		public class OpenWebBeansObjectFactoryTest {

[OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans #971

[OpenWebBeans] Add ObjectFactory for Apache OpenWebBeans #971

Conversation

rmannibucau commented Mar 8, 2016

stale bot commented Feb 12, 2018

rmannibucau commented Feb 12, 2018

stale bot commented Apr 13, 2018

stale bot commented Apr 20, 2018

lock bot commented Apr 20, 2019

mpkorstanje left a comment

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019 • edited Loading

Choose a reason for hiding this comment

mpkorstanje May 5, 2019 • edited Loading

Choose a reason for hiding this comment

mpkorstanje May 5, 2019 • edited Loading

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje May 5, 2019

Choose a reason for hiding this comment

mpkorstanje commented May 5, 2019

rmannibucau commented May 5, 2019

mpkorstanje commented May 5, 2019

rmannibucau commented May 5, 2019

toepi commented May 5, 2019

rmannibucau commented May 5, 2019

toepi commented May 6, 2019

mpkorstanje commented May 6, 2019 • edited Loading

rmannibucau commented May 6, 2019

rmannibucau commented May 10, 2019

lock bot commented May 20, 2020

lock bot commented May 20, 2020

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje May 5, 2019 •

edited

Loading

mpkorstanje commented May 6, 2019 •

edited

Loading