[JUnit] Add module-info for cucumber-junit-platform-engine #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
try-openjdk-for-javadoc
branch
2 times, most recently
from
9673390 to
98d1e01
Compare
mpkorstanje
changed the title
mpkorstanje
force-pushed
the
try-openjdk-for-javadoc
branch
2 times, most recently
from
b1eab6b to
0abd5bc
Compare
|
No |
|
https://travis-ci.community/t/add-support-for-maven-toolchain-plugin/5004
Looks like it is time to drop Travis for something else. |
|
The first https://stackoverflow.com/questions/31945809/skip-first-mvn-install-in-travis-ci |
mpkorstanje
changed the title
mpkorstanje
changed the title
Adds module-info for Cucumber Junit Platform Engine implementation.
This allows Java to ensure that all dependencies are available at
boot time.
To ensure backwards compatibility down to Java 8 we are using
multi-release jar files which will contain both Java 8 and
Java 9 class files.
To ensure the right JDK (OpenJDK 11) is used to build the project
the Maven Toolchains plugin will verify that this JDK is used.
This does require adding a `toolchains.xml` file to the ~/.m2/
folder.
Example:
```xml
<?xml version="1.0" encoding="UTF8"?>
<toolchains>
<toolchain>
<type>jdk</type>
<provides>
<version>11</version>
<vendor>openjdk</vendor>
</provides>
<configuration>
<jdkHome>/path/to/openjdk11</jdkHome>
</configuration>
</toolchain>
</toolchains>
```
mpkorstanje
force-pushed
the
try-openjdk-for-javadoc
branch
from
7603a28 to
bfd7342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds module-info for Cucumber Junit Platform Engine implementation.
This allows Java to ensure that all dependencies are available at
boot time.
To ensure backwards compatibility down to Java 8 we are using
multi-release jar files which will contain both Java 8 and
Java 9 class files.
To ensure the right JDK (OpenJDK 11) is used to build the project
the Maven Toolchains plugin will verify that this JDK is used.
This does require adding a
toolchains.xmlfile to the~/.m2/folder.
Example: