Skip to content

[Core] Remove publish token validation #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2020
Merged

[Core] Remove publish token validation #2123

merged 3 commits into from
Sep 15, 2020

Conversation

aslakhellesoy
Copy link
Contributor

This is a fix for #2122

@coveralls
Copy link

coveralls commented Sep 15, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.007%) to 86.492% when pulling b0ec951 on remove-publish-token-validation into fb86455 on main.

@mpkorstanje mpkorstanje changed the title Remove publish token validation [Core] Remove publish token validation Sep 15, 2020
mpkorstanje
mpkorstanje reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to add the changelog entry.

@aslakhellesoy
Copy link
Contributor Author

The revapi checks failed again. I wonder if it's possible to have it ignore anything that isn't part of the public API as described in SEMVER.md

@mpkorstanje
Copy link
Contributor

Unfortunately not.

@mpkorstanje mpkorstanje merged commit 538725b into main Sep 15, 2020
@mpkorstanje mpkorstanje deleted the remove-publish-token-validation branch September 15, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aslakhellesoy @coveralls @mpkorstanje